emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#34904: closed ([PATCH] Update elixir to 1.8.1.)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#34904: closed ([PATCH] Update elixir to 1.8.1.)
Date: Thu, 21 Mar 2019 19:56:01 +0000

Your message dated Thu, 21 Mar 2019 20:54:51 +0100
with message-id <address@hidden>
and subject line Re: [bug#34904] [PATCH] Update elixir to 1.8.1.
has caused the debbugs.gnu.org bug report #34904,
regarding [PATCH] Update elixir to 1.8.1.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34904: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34904
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] Update elixir to 1.8.1. Date: Mon, 18 Mar 2019 15:54:52 +0100 User-agent: Posteo Webmail
Hello,

Excited to be submitting my first patch to guix!
The following patch updates elixir from 1.6.6 to 1.8.1.
This was almost a trivial patch, however the full path of the git executable was causing a line to go over 80 chars, which caused a syntax check in the elixir Makefile to fail. I added a quick workaround to use elixir's own syntax checker to fix the affected file (by putting each argument to the fn on its own line)
before the test is run.

Best,

Robert

Attachment: 0001-Update-elixir-to-1.8.1.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: [bug#34904] [PATCH] Update elixir to 1.8.1. Date: Thu, 21 Mar 2019 20:54:51 +0100 User-agent: Notmuch/0.28.2 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu)
Hi Robert,

Robert Smith <address@hidden> writes:

> Hello,
>
> Excited to be submitting my first patch to guix!

It's a thrill, right? :-)

> The following patch updates elixir from 1.6.6 to 1.8.1.
> This was almost a trivial patch, however the full path of the git 
> executable
> was causing a line to go over 80 chars, which caused a syntax check in 
> the
> elixir Makefile to fail. I added a quick workaround to use elixir's own 
> syntax
> checker to fix the affected file (by putting each argument to the fn on 
> its own line)
> before the test is run.

Heh.  Nice workaround!  I added a commit message that follows our
convention, added the patch to "gnu/local.mk", and pushed the patch
in commit 2f87048dbe14097b9fe19ec470e2628cfca7fdbf.

Thank you, and welcome!

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]