--- Begin Message ---
|
Subject: |
Push mark in xref-push-marker-stack |
|
Date: |
Mon, 18 Mar 2019 23:12:50 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
X-Debbugs-CC: João Távora <address@hidden>, Dmitry Gutov <address@hidden>
Shouldn't xref-push-marker-stack push the mark like all normal commands do?
I know there is ‘M-,’ but why not allow using the standard keys
‘C-x C-SPC’ (pop-global-mark) and ‘C-u C-SPC’ (in the same file)
as well?
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 6974d00048..861e24a85f 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -365,6 +365,7 @@ xref-set-marker-ring-length
(defun xref-push-marker-stack (&optional m)
"Add point M (defaults to `point-marker') to the marker stack."
+ (push-mark nil t)
(ring-insert xref--marker-ring (or m (point-marker))))
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#34908: Push mark in xref-push-marker-stack |
|
Date: |
Sun, 24 Mar 2019 23:20:19 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
>> So I don't know what to write in NEWS, something along the lines:
>> "like all commands that move to a far away position
>> xref-find-definitions now sets the mark as well
>> but please remember that the primary way to pop xref mark
>> is still M-, (xref-pop-marker-stack)" ?
>
> Just
>
> xref-find-definitions now sets the mark at the buffer position where
> it was invoked
>
> will do.
Done and pushed to master.
--- End Message ---