[debbugs-tracker] bug#35033: closed ([PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.)

[GNU bug Tracking System]

Your message dated Mon, 08 Apr 2019 10:29:54 +0200
with message-id <address@hidden>
and subject line Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 
'youtube-dl'.
has caused the debbugs.gnu.org bug report #35033,
regarding [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35033: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35033
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
>
>
>
>
> Date: 
>
> Thu, 28 Mar 2019 21:00:54 +0100
>
>
>
>
> * gnu/packages/video.scm (mpv)[arguments]: Add phase 'patch-paths' to
> substitute in the absolute path to 'youtube-dl'.
> ---
>  gnu/packages/video.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 55a1931530..3c5ade55a3 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1326,6 +1326,13 @@ SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
>      (arguments
>       '(#:phases
>         (modify-phases %standard-phases
> +         (add-after
> +          'unpack 'patch-paths
> +          (lambda* (#:key inputs #:allow-other-keys)
> +            (let ((ytdl (assoc-ref inputs "youtube-dl")))
> +              (substitute* "player/lua/ytdl_hook.lua"
> +                (("\"youtube-dl\",")
> +                 (string-append "\"" ytdl "/bin/youtube-dl\","))))))
>           (add-before
>            'configure 'setup-waf
>            (lambda* (#:key inputs #:allow-other-keys)
> -- 
> 2.21.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
>
>
>
>
> Date: 
>
> Mon, 08 Apr 2019 10:29:54 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Timo Eisenmann <address@hidden> skribis:
>
> > On Wed, 03 Apr 2019 22:24:12 +0200
> > Ludovic Courtès <address@hidden> wrote:
>
> [...]
>
> >> I think it’s a case where it may be more appropriate to look for
> >> ‘youtube-dl’ in $PATH because ‘youtube-dl’ is updated frequently.
> >> 
> >> WDYT?
> >
> > I think we should make mpv's youtube-dl feature work by default instead
> > of requiring the user to install youtube-dl into their profile.
>
> Arun Isaac <address@hidden> skribis:
>
> > We normally don't require the user to install dependencies such as
> > youtube-dl into the profile. I think we should retain that behaviour
> > even in this case with mpv. It would mean fewer surprises for the
> > user. If I'm guessing correctly, mpv doesn't require a lot of effort to
> > rebuild.
>
> Alright, that makes sense (and indeed, mpv builds very quickly.)
>
> I added a #t at the end of the phase and committed.
>
> Thank you!
>
> Ludo’.
>
>
> --- End Message ---