--- Begin Message ---
Subject: |
27.0.50; Some questions about choose-completion-string-functions |
Date: |
Wed, 06 Mar 2019 15:05:29 -0800 |
I'm trying to use `choose-completion-string-functions' to do some
"stuff" after the user finishes a completion, and have two questions:
1. The docstring of this variable says it is called with three
arguments, but in fact it's called with four: the fourth is passed as
nil, and is only there for backward compatibility, apparently. But
still, you can't use a function that only accepts three args. I can
provide a patch for the docstring if this is correct.
2. The code in `choose-completion-string' behaves as though the above
variable is buffer local, but it is never declared to be so. I'm not
sure if this is a bug (ie, we should be using `defvar-local'), or
whether I should be adding functions here using the (local 'SYMBOL)
convention of `add-function'. If that's the case, that's probably
also a docstring bug, as we should warn users that they'll want to
specify a local variable.
WDYT?
Eric
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) |
Date: |
Tue, 09 Apr 2019 20:16:36 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Noam Postavsky <address@hidden> writes:
> Eric Abrahamsen <address@hidden> writes:
>
>> So never mind! But I'd still like to add something like the attached, as
>> functions following the current docstring will raise an error.
>>
>> Eric
>>
>> diff --git a/lisp/simple.el b/lisp/simple.el
>> index d4ae5ebb1f..0274bdb459 100644
>> --- a/lisp/simple.el
>> +++ b/lisp/simple.el
>> @@ -8188,6 +8188,9 @@ choose-completion-string-functions
>> BUFFER - the buffer in which the choice should be inserted,
>> BASE-POSITION - where to insert the completion.
>>
>> +Functions should also accept and ignore a potential fourth
>> +argument, passed for backwards compatibility.
>> +
>
> Looks good to me. And it can go to emacs-26 since it's a doc fix.
Done, thanks.
Welcome back!
E
--- End Message ---