[debbugs-tracker] bug#35223: closed ([PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where needed.)

[GNU bug Tracking System]

Your message dated Sun, 14 Apr 2019 20:20:58 +0200
with message-id <address@hidden>
and subject line Re: [bug#35223] [PATCH] gnu: linux-libre: Set 
DEVPTS_MULTIPLE_INSTANCES only where needed.
has caused the debbugs.gnu.org bug report #35223,
regarding [PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where 
needed.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35223: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35223
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where needed.
>
>
>
>
> Date: 
>
> Thu, 11 Apr 2019 01:19:36 +0200
>
>
>
>
> From: Tobias Geerinckx-Rice <address@hidden>
>
> * gnu/packages/linux.scm (%default-extra-linux-options): Move obsolete
> CONFIG_DEVPTS_MULTIPLE_INSTANCES option…
> (linux-libre-4.4): …here.
> ---
>  gnu/packages/linux.scm | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 710fd2d299..c80cee6422 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -264,9 +264,7 @@ for ARCH and optionally VARIANT, or #f if there is no such 
> configuration."
>      (search-auxiliary-file file)))
>  
>  (define %default-extra-linux-options
> -  `(;; https://lists.gnu.org/archive/html/guix-devel/2014-04/msg00039.html
> -    ("CONFIG_DEVPTS_MULTIPLE_INSTANCES" . #t)
> -    ;; Modules required for initrd:
> +  `(;; Modules required for initrd:
>      ("CONFIG_NET_9P" . m)
>      ("CONFIG_NET_9P_VIRTIO" . m)
>      ("CONFIG_VIRTIO_BLK" . m)
> @@ -471,7 +469,13 @@ It has been modified to remove all non-free binary blobs.")
>    (make-linux-libre "4.4.178"
>                      "1lgsd760md6b32qb5ng3anfq1n754a9d0c4xnf2mjxkimncb1jpp"
>                      '("x86_64-linux" "i686-linux")
> -                    #:configuration-file kernel-config))
> +                    #:configuration-file kernel-config
> +                    #:extra-options
> +                    (append
> +                     `(;; 
> https://lists.gnu.org/archive/html/guix-devel/2014-04/msg00039.html
> +                       ;; This option was removed upstream in version 4.7.
> +                       ("CONFIG_DEVPTS_MULTIPLE_INSTANCES" . #t))
> +                     %default-extra-linux-options)))
>  
>  (define-public linux-libre-arm-generic
>    (make-linux-libre %linux-libre-version
> -- 
> 2.21.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#35223] [PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where needed. Date: Sun, 14 Apr 2019 20:20:58 +0200

Tobias Geerinckx-Rice wrote:

* gnu/packages/linux.scm (%default-extra-linux-options): Move
obsolete
CONFIG_DEVPTS_MULTIPLE_INSTANCES option…
(linux-libre-4.4): …here.

[…]

As long as things still work after this patch, go for it!

AFAICT: yes.

Pushed as 8b4e76249a4d1b4af5da6a8b07f4fb3c92234c07.

Kind regards,

T G-R

signature.asc
Description: PGP signature

--- End Message ---