[debbugs-tracker] bug#35588: closed (guix package --search does not search output names)

[GNU bug Tracking System]

Your message dated Thu, 09 May 2019 00:22:03 -0700
with message-id <address@hidden>
and subject line Re: bug#35588: [PATCH] ui: Search matches additional package 
outputs.
has caused the debbugs.gnu.org bug report #35588,
regarding guix package --search does not search output names
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35588: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35588
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: guix package --search does not search output names Date: Sun, 05 May 2019 12:39:05 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi,

mikadoZero reported a bug here:

https://lists.gnu.org/archive/html/help-guix/2019-04/msg00206.html

The bug is reproducible.  On Guix commit
aa7cdc57dc28673dedfc6ec210974aaa0099a419, a search for keyword "cargo"
does not find the "cargo" output of the "rust" package:

--8<---------------cut here---------------start------------->8---
$ guix package --search=cargo
name: chromium-bsu
version: 0.9.16.1
outputs: out
systems: x86_64-linux i686-linux armhf-linux aarch64-linux mips64el-linux
dependencies: address@hidden address@hidden address@hidden
+ address@hidden address@hidden
location: gnu/packages/games.scm:3295:2
homepage: http://chromium-bsu.sourceforge.net/
license: Clarified Artistic, Expat
synopsis: Fast-paced, arcade-style, top-scrolling space shooter  
description: In this game you are the captain of the cargo ship Chromium
+ B.S.U.  and are responsible for delivering supplies to the troops on the front
+ line.  Your ship has a small fleet of robotic fighters which you control from
+ the relative safety of the Chromium vessel.
relevance: 2
--8<---------------cut here---------------end--------------->8---

It should have printed all the "rust" packages, and the "mrustc"
package, since each of them has a "cargo" output.  Example:

--8<---------------cut here---------------start------------->8---
name: rust
version: 1.34.0
outputs: out doc cargo
systems: x86_64-linux i686-linux armhf-linux aarch64-linux mips64el-linux
dependencies: address@hidden address@hidden address@hidden address@hidden 
address@hidden
+ address@hidden address@hidden address@hidden address@hidden address@hidden
+ address@hidden address@hidden address@hidden address@hidden
location: gnu/packages/rust.scm:1026:4
homepage: https://www.rust-lang.org
license: ASL 2.0, Expat
synopsis: Compiler for the Rust progamming language  
description: Rust is a systems programming language that provides memory
+ safety and thread safety guarantees.
--8<---------------cut here---------------end--------------->8---

The general problem here is that Guix does not include outputs whose
name matches the given regex.  One might argue that we should simply add
the output's name to a searchable field, like the description, in cases
like this, but if it's easy to fix, we should just fix it.

-- 
Chris

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: bug#35588: [PATCH] ui: Search matches additional package outputs. Date: Thu, 09 May 2019 00:22:03 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Ludovic Courtès <address@hidden> writes:

> I would exclude only the standard output names used by (guix build
> gnu-build-system), so:
>
>   ("out" "doc" "debug" "lib" "include" "bin")
>
> That way one can still do ‘guix search git gui’ or ‘guix search bind utils’.

I didn't know you could do that!  Your suggestion makes sense.  I've
done as you suggest in commit 387e6b9e340ce4b401f220f72881415623a466f7.

Thanks everyone!  I'm closing this bug report.

-- 
Chris

signature.asc
Description: PGP signature

--- End Message ---