[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#35695: closed (27.0.50; Faces diff-added and diff-

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#35695: closed (27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal)
Date: Wed, 15 May 2019 19:11:02 +0000

Your message dated Wed, 15 May 2019 21:10:34 +0200
with message-id <address@hidden>
and subject line Re: bug#35695: 27.0.50; Faces diff-added and diff-removed look 
the same in a 256 color terminal
has caused the debbugs.gnu.org bug report #35695,
regarding 27.0.50; Faces diff-added and diff-removed look the same in a 256 
color terminal
to be marked as done.

(If you believe you have received this mail in error, please contact

35695: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35695
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Date: Sun, 12 May 2019 07:03:41 +0200

When using Emacs in a terminal that supports 256 colors (such as the built-in terminal on macOS), the faces diff-added and diff-removed look the same.

They are defined to have a background color of #eeffee and #ffeeee, respectively, in light background mode. When a diff is viewed in a terminal, they are both rendered using light grey background, so it's impossible to distinguish between them.

In Emac 26, they were defined using #ddffdd and #ffdddd, respectively, which is rendered fine in the terminal (on both Emacs 26 and 27).

One way to solve this is to add alternative color definitions using the "min-colors" requirement. Another is to go back to the old values.

     -- Anders Lindgren

In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29))
 of 2019-05-01 built on mbp.lan
Repository revision: 7dafbe3ab91e838803a84ab388bca03ff985e312
Repository branch: master
System Description:  Mac OS X 10.12.6

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
delete-backward-char: Text is read-only
Mark saved where search started
Making completion list...

Configured using:
 'configure --with-gnutls=no'

Configured features:

Important settings:
  value of $LC_CTYPE: UTF-8
  value of $LANG: en_SE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Apropos

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml
mml-sec password-cache epa derived epg epg-config gnus-util rmail
rmail-loaddefs text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch
multi-isearch help-mode cl-loaddefs cl-lib apropos smerge-mode
vc-dispatcher vc-svn diff-mode easymenu easy-mmode term/xterm xterm
elec-pair tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads kqueue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 56669 7188)
 (symbols 48 6625 1)
 (strings 32 17368 1666)
 (string-bytes 1 565596)
 (vectors 16 7835)
 (vector-slots 8 78808 10720)
 (floats 8 25 439)
 (intervals 56 860 4)
 (buffers 992 14))

--- End Message ---
--- Begin Message --- Subject: Re: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Date: Wed, 15 May 2019 21:10:34 +0200
On Tue, May 14, 2019 at 10:36 PM Juri Linkov <address@hidden> wrote:
> Should I include a comment describing why we need to treat 256 color
> displays differently?

Yes, comments are preferable because we don't have deffaces
with more than 88 min-colors anywhere else.

Thanks for the feedback!

I've pushed a patch fixing this issue.

    -- Anders

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]