--- Begin Message ---
|
Subject: |
log-view-diff regression |
|
Date: |
Wed, 08 May 2019 00:56:29 +0300 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
bug#28466 caused a regression in 26.0.50. Maybe it's too late to fix it
in the release branch, so the patch below is for master.
The problem is that after the change a year and a half ago
log-view-diff always falls back to the previous revision
even when point is in the middle of the log buffer,
and not after the last entry.
This patch uses the previous revision only at the end of the log buffer:
diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index e47fad8908..1f7d578610 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -618,10 +618,9 @@ log-view-diff-common
;; When TO and FR are the same, or when point is on a line after
;; the last entry, look at the previous revision.
(when (or (string-equal fr to)
- (>= (point)
- (save-excursion
- (goto-char (car fr-entry))
- (forward-line))))
+ (save-excursion
+ (goto-char end)
+ (eobp)))
(setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil
fr)))
(vc-diff-internal
t (list log-view-vc-backend
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#35624: log-view-diff regression |
|
Date: |
Sun, 19 May 2019 23:11:41 +0300 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
> Yes, I believe a try is worth a thousand words.
So let's try this. Pushed to master.
--- End Message ---