[debbugs-tracker] bug#35854: closed ([PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.)

[GNU bug Tracking System]

Your message dated Fri, 24 May 2019 18:05:03 +0200
with message-id <address@hidden>
and subject line Re: [bug#35854] [PATCH] lxqt: lxqt-panel: fix taskbar plugin's 
application list issue.
has caused the debbugs.gnu.org bug report #35854,
regarding [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35854: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35854
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.
>
>
>
>
> Date: 
>
> Wed, 22 May 2019 11:57:16 +0430
>
>
>
>
> * gnu/packages/lxqt.scm (lxqt-panel): move `kwindowsystem` from `inputs`
> to `propagated-inputs`
> ---
>  gnu/packages/lxqt.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index d91efe715d..a03a93e5c5 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <address@hidden>
>  ;;; Copyright © 2018, 2019 Meiyo Peng <address@hidden>
>  ;;; Copyright © 2018 Ricardo Wurmus <address@hidden>
> +;;; Copyright © 2019 Reza Alizadeh Majd <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -559,7 +560,6 @@ of other programs.")
>      (inputs
>       `(("alsa-lib" ,alsa-lib)
>         ("kguiaddons" ,kguiaddons)
> -       ("kwindowsystem" ,kwindowsystem)
>         ("libdbusmenu-qt" ,libdbusmenu-qt)
>         ("liblxqt" ,liblxqt)
>         ("libqtxdg" ,libqtxdg)
> @@ -582,6 +582,8 @@ of other programs.")
>       `(("pkg-config" ,pkg-config)
>         ("lxqt-build-tools" ,lxqt-build-tools)
>         ("qttools" ,qttools)))
> +    (propagated-inputs
> +      `(("kwindowsystem" ,kwindowsystem)))
>      (arguments
>       '(#:tests? #f                      ; no tests
>         #:phases
> -- 
> 2.19.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#35854] [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.
>
>
>
>
> Date: 
>
> Fri, 24 May 2019 18:05:03 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Reza Alizadeh Majd <address@hidden> skribis:
>
> > * gnu/packages/lxqt.scm (lxqt-panel): move `kwindowsystem` from `inputs`
> > to `propagated-inputs`
>
> Applied, but I added a comment based on your message (see below).  In
> general, ‘propagated-inputs’ should be used only when strictly
> necessary, so when we use them, it’s important to add comments
> explaining why we do so.
>
> Thanks for the patch!
>
> Ludo’.
>
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index c3b25e5417..a8699b3d09 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -583,7 +583,9 @@ of other programs.")
>         ("lxqt-build-tools" ,lxqt-build-tools)
>         ("qttools" ,qttools)))
>      (propagated-inputs
> -      `(("kwindowsystem" ,kwindowsystem)))
> +     ;; Propagating KWINDOWSYSTEM so that the list of opened applications
> +     ;; shows up in lxqt-panel's taskbar plugin.
> +     `(("kwindowsystem" ,kwindowsystem)))
>      (arguments
>       '(#:tests? #f                      ; no tests
>         #:phases
>
> --- End Message ---