[debbugs-tracker] bug#35859: closed ([PATCH] hackage import: Setup.hs generation and revision support)

[GNU bug Tracking System]

Your message dated Sun, 26 May 2019 23:23:27 +0200
with message-id <address@hidden>
and subject line Re: [bug#35812] [PATCH] fix hackage cabal tests
has caused the debbugs.gnu.org bug report #35812,
regarding [PATCH] hackage import: Setup.hs generation and revision support
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35812: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35812
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] hackage import: Setup.hs generation and revision support Date: Wed, 22 May 2019 22:11:50 +0200

These patches are on top of

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35812 (fix cabal tests)
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35846 (braced properties)

- substitute missing Setup.hs and remove manual per-package workarounds
- handle hackage metadata revisions

I believe the code works, but some may not be the most idiomatic scheme
code. Particularly around building the quoted argument list and returning
a pair of cabal data and hash.

0001-gnu-ghc-easy-plot-remove-superfluous-Setup.hs-rename.patch
Description: Binary data

0002-guix-haskell-build-system-correct-haddock-phase-docu.patch
Description: Binary data

0003-guix-haskell-build-system-generate-Setup.hs-if-not-e.patch
Description: Binary data

0004-gnu-haskell-leave-Setup.hs-generation-to-build-syste.patch
Description: Binary data

0005-guix-import-hackage-handle-hackage-revisions.patch
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#35812] [PATCH] fix hackage cabal tests
>
>
>
>
> Date: 
>
> Sun, 26 May 2019 23:23:27 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Robert Vollmert <address@hidden> skribis:
>
> >> On 21. May 2019, at 16:48, Ludovic Courtès <address@hidden> wrote:
> >> Robert Vollmert <address@hidden> skribis:
> >> 
> >>> Hackage cabal tests didn’t run independently due to memoization,
> >>> and test-cabal-6 was failing.
> >> 
> >> I don’t think memoization can get in the way here: the argument list is
> >> used as a key in the memoization hash table.  Thus, if you pass
> >> different arguments, you get a cache miss and call the underlying
> >> procedure.
> >> 
> >> Or am I missing something?
> >
> > I agree that memoization of a pure function shouldn’t have such effects,
> > but my (limited) understanding is that hackage->guix-packages would
> > cache import results by package name on the assumption that cabal
> > files for the same package name don’t change between calls.
>
> Oh, got it.
>
> I pushed a variant of the patch as commit
> ad7466aafd7f166d0b6be5eb32dda1d3ee8a6445.
>
> Thanks!
>
> Ludo’.
>
>
> --- End Message ---