[debbugs-tracker] bug#35345: closed ([PATCH 0/2] Add missing run-time dependency for TLP (Power management tool for Linux).)

[GNU bug Tracking System]

Your message dated Mon, 27 May 2019 16:43:24 +0200
with message-id <address@hidden>
and subject line Re: [bug#35345] [PATCH 2/2] gnu: tlp: Add required 
x86-energy-perf-policy input dependency.
has caused the debbugs.gnu.org bug report #35345,
regarding [PATCH 0/2] Add missing run-time dependency for TLP (Power management 
tool for Linux).
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35345: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35345
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] Add missing run-time dependency for TLP (Power management tool for Linux).
>
>
>
>
> Date: 
>
> Sat, 20 Apr 2019 16:26:31 +0000
>
>
>
>
> Hello.
>
> The first patch will add system (arch-kernel) specific
> x86-energy-perf-policy package,
> and the second patch will adjust TLP package to use
> x86-energy-perf-policy as a optional/system-specific run-time
> dependency.
>
> To understand my motivation please take a look at:
> - https://linrunner.de/en/tlp/docs/tlp-configuration.html#scaling
> the section explaining ENERGY_PERF_POLICY_ON_AC parameter has the
> following note:
> "Important: this setting requires the kernel module msr and the tool
> x86_energy_perf_policy matching your kernel version."
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#35345] [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input dependency.
>
>
>
>
> Date: 
>
> Mon, 27 May 2019 16:43:24 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Stefan Stefanović <address@hidden> skribis:
>
> > From a7264289ba328478a1dab1978fe080a5b4f392c2 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Stefan=20Stefanovi=C4=87?= <address@hidden>
> > Date: Sat, 20 Apr 2019 16:13:37 +0200
> > Subject: [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input
> >  dependency.
> >
> > * gnu/packages/linux.scm (tlp)
> > [inputs]: Add system specific x86-energy-perf-policy dependency.
> > [arguments]<#:phases>['wrap]:
> > Adjust bin-directory procedure to return #f on missing input,
> > a guard against system specific input dependencies.
> > Filter only strings in the path list. Reformat for-each block.
> > Add x86-energy-perf-policy in bin-directory input-name list.
>
> I reworded it to use ‘filter-map’ intead of (filter string? …).
>
> > +              ,@(if (member (or (%current-target-system) (%current-system))
> > +                            (package-supported-systems 
> > x86-energy-perf-policy))
>
> This would not work, because ‘%current-target-system’ returns a
> “triplet”, not a “system type”, so I’ve also rephrased it.
>
> Let me know if something’s broken!
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---