[debbugs-tracker] bug#36543: closed ([PATCH] gnu: wireservice: New wireservice-package macro.)

[GNU bug Tracking System]

Your message dated Mon, 08 Jul 2019 12:57:28 +0200
with message-id <address@hidden>
and subject line Re: [bug#36543] [PATCH] gnu: wireservice: New 
wireservice-package macro.
has caused the debbugs.gnu.org bug report #36543,
regarding [PATCH] gnu: wireservice: New wireservice-package macro.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36543: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36543
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] gnu: wireservice: New wireservice-package macro. Date: Sun, 07 Jul 2019 22:02:47 +0100 User-agent: mu4e 1.2.0; emacs 26.2

Hi Guix, Ludo,

Here's a new 'wireservice-package' macro that factors the packages that
used to inherit for a base package with '#f fields. The main change is
that native-inputs are no longer common, I toyed with a more complicated
macro that would allow extending them but in the end I think the simpler
the better!

WDYT?

Thanks for the suggestion! I need to learn me some more macro magic,
it's fun :-).

Pierre

0001-gnu-wireservice-New-wireservice-package-macro.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#36543] [PATCH] gnu: wireservice: New wireservice-package macro.
>
>
>
>
> Date: 
>
> Mon, 08 Jul 2019 12:57:28 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Pierre Langlois <address@hidden> skribis:
>
> > Here's a new 'wireservice-package' macro that factors the packages that
> > used to inherit for a base package with '#f fields. The main change is
> > that native-inputs are no longer common, I toyed with a more complicated
> > macro that would allow extending them but in the end I think the simpler
> > the better!
> >
> > WDYT?
>
> I think it looks good this way!
>
> There’s a bit of code bloat because the macro expands the ‘arguments’
> field for every package, but it doesn’t matter much here (it’d be more
> of a problem if we had 100s of packages all duplicating that field.)
>
> > Thanks for the suggestion! I need to learn me some more macro magic,
> > it's fun :-).
>
> Yup!  :-)
>
> > From cf7559db69dd1d829e620c6b31e253a2d8911eff Mon Sep 17 00:00:00 2001
> > From: Pierre Langlois <address@hidden>
> > Date: Sun, 7 Jul 2019 16:02:26 +0100
> > Subject: [PATCH] gnu: wireservice: New wireservice-package macro.
> >
> > Replace the parent 'base-package' variable with a 'wireservice-package' macro
> > that includes all common package fields.
> >
> > * gnu/packages/wireservice.scm (base-package): Delete.
> > (wireservice-package): New macro.
> > (python-leather, python-agate, python-agate-sql, python-agate-dbf,
> > python-agate-excel): Use wireservice-package.
>
> Applied, thanks for the quick followup!
>
> Ludo’.
>
>
> --- End Message ---