[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[debbugs-tracker] bug#37420: closed ([PATCH] Recommend against SHA-1 for
From: |
GNU bug Tracking System |
Subject: |
[debbugs-tracker] bug#37420: closed ([PATCH] Recommend against SHA-1 for security-related applications) |
Date: |
Fri, 04 Oct 2019 15:35:02 +0000 |
Your message dated Fri, 4 Oct 2019 17:33:54 +0200
with message-id <CADwFkmkS4KwO0H5DNmxSfAdQ88bDzSkMfJ6Pj6MDrkbnV=address@hidden>
and subject line Re: bug#37420: [PATCH] Recommend against SHA-1 for
security-related applications
has caused the debbugs.gnu.org bug report #37420,
regarding [PATCH] Recommend against SHA-1 for security-related applications
to be marked as done.
(If you believe you have received this mail in error, please contact
address@hidden.)
--
37420: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37420
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message ---
Subject: |
[PATCH] Recommend against SHA-1 for security-related applications |
Date: |
Mon, 16 Sep 2019 10:53:27 +0200 |
SHA-1 has now seen collision attacks:
https://www.zdnet.com/article/sha-1-collision-attacks-are-now-actually-practical-and-a-looming-danger/
We should clarify that these attacks are not only theoretical, and
actively discourage using it in security-related applications in the
Elisp Manual. The attached patch is an attempt at doing that.
Any comments?
Best regards,
Stefan Kangas
0001-Recommend-against-SHA-1-for-security-related-applica.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#37420: [PATCH] Recommend against SHA-1 for security-related applications |
Date: |
Fri, 4 Oct 2019 17:33:54 +0200 |
Lars Ingebrigtsen <address@hidden> writes:
> > Thanks Eli and Robert. How about the attached patch?
>
> Looks good to me, but one tiny thing:
>
> > +(ert-deftest test-secure-hash ()
> > + (should (equal (secure-hash 'md5 "foobar")
> > "3858f62230ac3c915f300c664312c63f"))
> > + (should (equal (secure-hash 'sha1 "foobar")
> > "8843d7f92416211de9ebb963ff4ce28125932878"))
> > + (should (equal (secure-hash 'sha224 "foobar") (concat
> > "de76c3e567fca9d246f5f8d3b2e704a3"
> > +
> > "8c3c5e258988ab525f94
>
> Perhaps the lines should be folded to avoid too-long lines?
Thanks; fixed and pushed as commit ef8fadf8c1.
Best regards,
Stefan Kangas
--- End Message ---
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [debbugs-tracker] bug#37420: closed ([PATCH] Recommend against SHA-1 for security-related applications),
GNU bug Tracking System <=