--- Begin Message ---
Subject: |
rcirc: nil gets interpreted as a nickname |
Date: |
Sun, 8 Sep 2019 20:58:59 +0200 |
Severity: normal
Ever since I changed my nickname to "nil" on Freenode, I've been
getting occasional private messages from unknown users consisting of a
single empty CTCP ACTION. After a bit of investigating, it turned out
they all used rcirc. The situation was clear at that point: somewhere
in rcirc's source code, a nil value is being implicitly converted to a
string and used as the target of a PRIVMSG command.
The bug seems to be reproducible by issuing "/me" (without arguments)
inside a server buffer: the "nil" user on that server gets sent an
empty ACTION.
Suggested fix: in rcirc-send-privmsg, fail if target is nil. It might
be useful to check other places where the "%s" format is used, to
discover similar bugs.
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#37344: rcirc: nil gets interpreted as a nickname |
Date: |
Mon, 07 Oct 2019 19:01:29 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (macOS 10.14.6) |
Version: 26.4
On 2019-10-07 06:55 +0200, Lars Ingebrigtsen wrote:
> I have no objections; please go ahead.
I have committed the change to emacs-26. Thanks.
--- End Message ---