bug#37755: closed (Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap))

[GNU bug Tracking System]

Your message dated Sat, 26 Oct 2019 13:11:09 -0300
with message-id <CAELgYhft-4CLC8d=R8AQS5bgDFJXM-29R=+address@hidden>
and subject line Re: bug#37755: Logic in init_fringe_bitmap should be moved to 
backends (maybe rif->define_fringe_bitmap)
has caused the debbugs.gnu.org bug report #37755,
regarding Logic in init_fringe_bitmap should be moved to backends (maybe 
rif->define_fringe_bitmap)
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
37755: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37755
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap)
>
>
>
>
> Date: 
>
> Mon, 14 Oct 2019 23:30:08 -0300
>
>
>
>
> In fringe.c you have init_fringe_bitmap with this structure:
>
> ```
> #if defined (HAVE_X_WINDOWS)
> ...
> #ifdef USE_CAIRO
> ...
> #endif
> ...
> #endif
> #ifdef HAVE_NTGUI
> ...
> #endif
>   if (!once_p)
>     {
>     ....
>     rif->define_fringe_bitmap (...)
>     ....
>     }
> ```
>
> Now, this is backend specific code that should be moved behind the
> redisplay_interface. It seems to me that the obvious candidate to host
> that code is define_fringe_bitmap. The once_p clause is related to
> pdumper which I ignore all about.
>
> Best regards
> --
> Carlos
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) Date: Sat, 26 Oct 2019 13:11:09 -0300

I don't think you can do that with a RIF, for the reason already
mentioned: Emacs is dumped in batch mode, where we have a frame type
that doesn't support fringes, and doesn't implement the RIF interfaces
you will need.

Ok, I'm not eager to rework this, so if you think that avoiding repeating that bit shuffling at the beginning is worth the additional coupling and complexity I trust in your criterion and close this issue. Thanks.

--- End Message ---