bug#38477: closed ([PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services.)

[GNU bug Tracking System]

Your message dated Wed, 4 Dec 2019 08:32:31 -0500
with message-id <address@hidden>
and subject line Re: [bug#38477] [PATCH] services: SSH services: Provide 'ssh' 
and 'sshd' Shepherd services.
has caused the debbugs.gnu.org bug report #38477,
regarding [PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd 
services.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38477: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38477
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services.
>
>
>
>
> Date: 
>
> Tue,  3 Dec 2019 15:00:27 -0500
>
>
>
>
> This should improve the "user experience" when querying the status of
> the SSH service.  We could even add program specific strings like
> "lshd", "dropbear", and "openssh".  Thoughts?
>
> * gnu/services/ssh.scm (lsh-shepherd-service, dropbear-shepherd-service,
> openssh-sheperd-service): Add 'ssh' and 'sshd' to provision.
> ---
>  gnu/services/ssh.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm
> index ced1991fba..7e25810eff 100644
> --- a/gnu/services/ssh.scm
> +++ b/gnu/services/ssh.scm
> @@ -174,7 +174,7 @@
>  
>    (list (shepherd-service
>           (documentation "GNU lsh SSH server")
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (requirement requires)
>           (start #~(make-forkexec-constructor (list #$@lsh-command)))
>           (stop  #~(make-kill-destructor)))))
> @@ -511,7 +511,7 @@ of user-name/file-like tuples."
>    (list (shepherd-service
>           (documentation "OpenSSH server.")
>           (requirement '(syslogd loopback))
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (start #~(make-forkexec-constructor #$openssh-command
>                                               #:pid-file #$pid-file))
>           (stop #~(make-kill-destructor))
> @@ -620,7 +620,7 @@ of user-name/file-like tuples."
>    (list (shepherd-service
>           (documentation "Dropbear SSH server.")
>           (requirement requires)
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (start #~(make-forkexec-constructor #$dropbear-command
>                                               #:pid-file #$pid-file))
>           (stop #~(make-kill-destructor)))))
> -- 
> 2.24.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#38477] [PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services.
>
>
>
>
> Date: 
>
> Wed, 4 Dec 2019 08:32:31 -0500
>
>
>
>
> User-agent: 
>
> Mutt/1.12.2 (2019-09-21)
>
>
>
>
> On Tue, Dec 03, 2019 at 09:06:28PM -0600, Brett Gilio wrote:
> > Leo Famulari <address@hidden> writes:
> > 
> > > This should improve the "user experience" when querying the status of
> > > the SSH service.  We could even add program specific strings like
> > > "lshd", "dropbear", and "openssh".  Thoughts?
> > 
> > I think this is a good idea. It would add a lot of granular
> > control. However, we would need to make sure this is a standard used for
> > other SSH options in the future.
>
> Okay, all are welcome to make this change :)
>
> > LGTM! Very simple solution. Should be easy to cross-implement to other uses.
>
> Thanks! Pushed as 1a7633c2397714c492482282da670e47f7dc8177
>
>
> --- End Message ---