emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34698: closed ([PATCH] gnu: add org-noter.)


From: GNU bug Tracking System
Subject: bug#34698: closed ([PATCH] gnu: add org-noter.)
Date: Tue, 10 Dec 2019 04:57:01 +0000

Your message dated Mon, 09 Dec 2019 22:55:51 -0600
with message-id <address@hidden>
and subject line Re: [bug#34698] [PATCH] gnu: add org-noter.
has caused the debbugs.gnu.org bug report #34698,
regarding [PATCH] gnu: add org-noter.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
34698: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34698
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] gnu: add org-noter. Date: Fri, 1 Mar 2019 09:07:52 +0100
---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 871721af3a..decab4f292 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9285,6 +9285,38 @@ timestamps and date-time format strings library for 
Emacs.")
        "This package creates Graphviz directed graphs from Org files.")
       (license license:gpl3+))))
 
+(define-public emacs-org-noter
+  (package
+    (name "emacs-org-noter")
+    (version "1.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://stable.melpa.org/packages/org-noter-";
+             version
+             ".el"))
+       (sha256
+        (base32
+         "1hczwva73gsyanl1ldhdvql01gy0hy2g861yzkaklyb763sx58x4"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-org" ,emacs-org)))
+    (home-page
+     "https://github.com/weirdNox/org-noter";)
+    (synopsis
+     "A synchronized, Org-mode, document annotator")
+    (description
+     "The idea is to let you create notes that are kept in sync when you 
scroll through the
+document, but that are external to it - the notes themselves live in an 
Org-mode file. As
+such, this leverages the power of Org-mode (the notes may have outlines, latex 
fragments,
+babel, etc...) while acting like notes that are made /in/ the document.
+
+Also, I must thank Sebastian for the original idea and inspiration!
+Link to the original Interleave package:
+https://github.com/rudolfochrist/interleave
+")
+    (license license:gpl3)))
+
 (define-public emacs-npm-mode
   (package
     (name "emacs-npm-mode")
-- 
2.20.1




--- End Message ---
--- Begin Message --- Subject: Re: [bug#34698] [PATCH] gnu: add org-noter. Date: Mon, 09 Dec 2019 22:55:51 -0600 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Ludovic Courtès <address@hidden> writes:

> Hello,
>
> Nicolò Balzarotti <address@hidden> skribis:
>
>> ---
>>  gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>
> Could you add a commit log that follows our conventions?
>
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://stable.melpa.org/packages/org-noter-";
>> +             version
>> +             ".el"))
>
> Since files on MELPA are unversioned and regularly modified in place,
> could you instead use the upstream URL (presumably the GitHub repo)?
>
>> +    (synopsis
>> +     "A synchronized, Org-mode, document annotator")
>          ^
> ‘guix lint’ probably complains about this; please remove the “A”.
>
>> +    (description
>> +     "The idea is to let you create notes that are kept in sync when you 
>> scroll through the
>> +document, but that are external to it - the notes themselves live in an 
>> Org-mode file. As
>> +such, this leverages the power of Org-mode (the notes may have outlines, 
>> latex fragments,
>> +babel, etc...) while acting like notes that are made /in/ the document.
>> +
>> +Also, I must thank Sebastian for the original idea and inspiration!
>> +Link to the original Interleave package:
>> +https://github.com/rudolfochrist/interleave
>
> Please change the description to describe the package contents from the
> viewpoint of an outsider.  See the guidelines at
> <https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.
>
>> +    (license license:gpl3)))
>
> The source file header explicitly says “or any later version”, so it
> should be ‘license:gpl3+’.
>
> Could you send an updated patch?
>
> Thank you,
> Ludo’.
>
>
>
>

Hi Ludo' and Nicolò,

Closing this as it was added in commit
576cb396eac4e8cea2b54d96382f8e77f3584e89 on 2019-06-13.

Thanks!

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]