|
From: | GNU bug Tracking System |
Subject: | bug#37927: closed (Better handle license expressions in 'guix import crate') |
Date: | Wed, 11 Dec 2019 13:02:03 +0000 |
Your message dated Wed, 11 Dec 2019 12:24:04 +0100 with message-id <address@hidden> and subject line Re: [bug#37928] [PATCH v2] import: crate: Better handle license expressions. has caused the debbugs.gnu.org bug report #37927, regarding Better handle license expressions in 'guix import crate' to be marked as done. (If you believe you have received this mail in error, please contact address@hidden.) -- 37927: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37927 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: Date: Fri, 25 Oct 2019 22:27:12 +0200 This patch should allow correctly importing most of the licenses from crates.io. Before it, importing recursively ripgrep would result in ~140 missing licenses; now none seems missing.
--- End Message ---
--- Begin Message ---Subject: Re: [bug#37928] [PATCH v2] import: crate: Better handle license expressions. Date: Wed, 11 Dec 2019 12:24:04 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Hi Brice, Brice Waegeneire <address@hidden> skribis: > * guix/import/crate.scm (%dual-license-rx): Removed function. > (crate->guix-package): Handle most of the multi-licensing cases. > * tests/crate.scm (licenses): Add tests for some licenses. Thanks for the updated patch! > +(define (string->license string) > + (map > + spdx-string->license > + (filter (lambda (license) > + (and (not (string-null? license)) > + (not (any (lambda (elem) (string=? elem license)) > + '("AND" "OR" "WITH"))))) > + (string-split string (string->char-set " /"))))) I changed that to use ‘filter-map’ instead and pushed as 263a267b75e472cb84428571580dabd99d5dff0c. Thanks! Ludo’.
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |