bug#38630: closed (Software Heritage (swh): Fix API change, causing repeatedly submitting archives)

[GNU bug Tracking System]

Your message dated Tue, 17 Dec 2019 23:32:40 +0100
with message-id <20191217233240.09d4166a@alma-ubu>
and subject line Re: [bug#38630] Software Heritage (swh): Fix API change, 
causing repeatedly submitting archives
has caused the debbugs.gnu.org bug report #38630,
regarding Software Heritage (swh): Fix API change, causing repeatedly 
submitting archives
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38630: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38630
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Software Heritage (swh): Fix API change, causing repeatedly submitting archives Date: Sun, 15 Dec 2019 22:34:33 +0100

Hi Guix,

when linting, I recognized that the archival linter was repeatedly
sending packages to the SWH, despite that the package was already
archived.

With some investigations, I noticed they changed the API. Here's a
patch that fixes it.

I have not communicated with SWH about that, especially I have not asked
SWH why they broke the API without updating the version number.

Björn

0001-swh-Fix-API-call-for-getting-origin.patch
Description: Text Data

pgpMRBri3Lt3X.pgp
Description: OpenPGP digital signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#38630] Software Heritage (swh): Fix API change, causing repeatedly submitting archives Date: Tue, 17 Dec 2019 23:32:40 +0100

On Tue, 17 Dec 2019 17:41:04 +0100
Ludovic Courtès <address@hidden> wrote:

> > I have not communicated with SWH about that, especially I have not
> > asked SWH why they broke the API without updating the version
> > number.  
> 
> Yeah, that’s weird, I’ve pinged them on IRC.
> 
> It seems that the removal was intentional as part of
> <https://forge.softwareheritage.org/D2167>, but it wasn’t clear
> whether the API breakage should have happened.  This led them to open
> a new task: <https://forge.softwareheritage.org/T2158>.  We should
> keep an eye on it.

I will be frequently linting and see what's happening :-)

[..]

> In the meantime, your patch looks like the right move, so you can
> push it.

Thanks for your review and further information, pushed as

356a79becc4061d158c68718ad169abac1ab672f

Closing this ticket.

Björn

pgpI09snQvZ58.pgp
Description: OpenPGP digital signature

--- End Message ---