bug#38416: closed (27.0.50;; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message)

[GNU bug Tracking System]

Your message dated Thu, 16 Jan 2020 16:12:01 -0800
with message-id <address@hidden>
and subject line regexp-quote the param in makefile-move-to-macro to avoid 
error message
has caused the debbugs.gnu.org bug report #39094,
regarding 27.0.50;; [PATCH] * makefile-edit.el: regexp-quote the param in 
makefile-move-to-macro to avoid error message
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39094: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39094
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 27.0.50;; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message Date: Thu, 28 Nov 2019 21:25:10 +0800

[PATCH] * makefile-edit.el: regexp-quote the param in

makefile-move-to-macro.

 

Fix the error message from `makefile-move-to-macro' when there is '$'

or '\\' in param for re-search-forward, with `(global-ede-mode t)' and

`(semantic-mode t)' enabled. Enable ede and semantic mode, then open a

Makefile.am in which has line 'AM_LIBTMP_LIBS:=$(shell X \--libs)'

will trigger the error message, and this patch fix that.

---

lisp/cedet/ede/makefile-edit.el | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/lisp/cedet/ede/makefile-edit.el

b/lisp/cedet/ede/makefile-edit.el

index 7d8a44b..add1675 100644

--- a/lisp/cedet/ede/makefile-edit.el

+++ b/lisp/cedet/ede/makefile-edit.el

@@ -78,7 +78,7 @@ makefile-move-to-macro

If NEXT is non-nil, move to the next occurrence of MACRO."

   (let ((oldpt (point)))

     (when (not next) (goto-char (point-min)))

-    (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=") nil t)

+    (if (re-search-forward (concat "^\\s-*" (regexp-quote macro)

"\\s-*[+:?]?=") nil t)

        t

       (goto-char oldpt)

       nil)))

--

2.2.0

 

 

 

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> regexp-quote the param in makefile-move-to-macro to avoid error message
>
>
>
>
> Date: 
>
> Thu, 16 Jan 2020 16:12:01 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1
>
>
>
>
> Thanks for reporting that bug. I installed your patch into the master 
> branch.
>
>
> --- End Message ---