[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39214: closed (Updates to etc/guix-install.sh)

From: GNU bug Tracking System
Subject: bug#39214: closed (Updates to etc/guix-install.sh)
Date: Sun, 26 Jan 2020 22:21:01 +0000

Your message dated Sun, 26 Jan 2020 23:19:51 +0100
with message-id <address@hidden>
and subject line Re: [bug#39214] Updates to etc/guix-install.sh
has caused the debbugs.gnu.org bug report #39214,
regarding Updates to etc/guix-install.sh
to be marked as done.

(If you believe you have received this mail in error, please contact

39214: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39214
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Updates to etc/guix-install.sh Date: Tue, 21 Jan 2020 12:56:34 +0545
Esteemed Maintainer,

Attached are two patches as a follow-up to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39049 that was just recently applied to the main source tree.

Patch 1 exports the INFOPATH and makes the up-to-date guix info manual available to the user via both /usr/bin/info and $GUIX_PROFILE/bin/info (previously `info guix` would either show the out-of-date info file installed during installation or throw a "No menu item 'guix' in node '(dir)Top" error if the $GUIX_PROFILE/bin/info was invoked, or if the info pages weren't installed during installation).

Patch 2 adds a defensive test against (highly unlikely) cases where /etc/profile.d might not exist, and creates it. The function does not quit on failure because it is possible that /etc/profile is still configured to read /etc/profile.d/*.sh files. Even if it is not, guix.sh will merely sit in /etc/profile.d and cause no changes to the user's environment.

These changes caused no regressions in my local machine.

I hope this helps more foreign distro users in their journey with Guix.

Attachment: 0001-guix-install.sh-Export-INFOPATH-to-contain-updated-g.patch
Description: Text Data

Attachment: 0002-guix-install.sh-Create-etc-profile.d-if-it-does-not-.patch
Description: Text Data

--- End Message ---
--- Begin Message --- Subject: Re: [bug#39214] Updates to etc/guix-install.sh Date: Sun, 26 Jan 2020 23:19:51 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Prafulla Giri <address@hidden> skribis:

> From 0f98891feb2cc3cb4c529c65d789cdfc955cfc41 Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <address@hidden>
> Date: Tue, 21 Jan 2020 12:25:24 +0545
> Subject: [PATCH 1/2] guix-install.sh: Export INFOPATH to contain updated guix
>  info-pages
> * etc/guix-install.sh (sys_create_init_profile): Export INFOPATH to include
> the updated info-pages from ~/.config/guix/current/share/info.  This also 
> makes
> sure that both /usr/bin/info and $GUIX_PROFILE/bin/info can read guix info 
> pages
> without throwing "no menu item 'guix' in node dir(Top)" error.

> From dcd2180c36dc0319ebc3ab821879015e30bba94e Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <address@hidden>
> Date: Tue, 21 Jan 2020 12:34:10 +0545
> Subject: [PATCH 2/2] guix-install.sh: Create /etc/profile.d if it does not
>  exist
> * etc/guix-install.sh (sys_create_init_profile): Add code to create
> /etc/profile.d if it somehow does not exist; the function still carries
> on because it is possible that /etc/profile is still configured to read
> the *.sh files from /etc/profile.d, if they exist.

Applied both, thank you!


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]