bug#39291: closed (M-: history doesn't store erroneous input)

[GNU bug Tracking System]

Your message dated Fri, 31 Jan 2020 11:20:20 +0200
with message-id <address@hidden>
and subject line Re: bug#39291: M-: history doesn't store erroneous input
has caused the debbugs.gnu.org bug report #39291,
regarding M-: history doesn't store erroneous input
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39291: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39291
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: M-: history doesn't store erroneous input Date: Sun, 26 Jan 2020 16:16:23 +0100

M-: (oops-i-forgot-to-type-the-closing-paren RET

=> End of file during parsing

Error itself is fine, but the problem is if you now

type M-: again, you won't find your input in the

history and have to retype everything from scratch

instead of just fixing the typo.

This is a regression in trunk compared at least to

26.3.

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#39291: M-: history doesn't store erroneous input
>
>
>
>
> Date: 
>
> Fri, 31 Jan 2020 11:20:20 +0200
>
>
>
>
> > From: Federico Tedin <address@hidden>
> > Cc: Eli Zaretskii <address@hidden>,  address@hidden,  address@hidden,  Juri 
> > Linkov <address@hidden>
> > Date: Fri, 31 Jan 2020 01:44:34 +0100
> > 
> > > AFAIK they don't depend on Lisp variables, no, so it should be safe to
> > > move the call to `string_to_object` to after the `unbind_to`.
> > >
> > Thanks for the information. In that case, the patch I sent should be the
> > right fix for this bug.
>
> Thanks, pushed to the release branch.
>
> > * src/minibuf.c (read_minibuf): Parse input string after saving the
> > string to the history list instead of before, in case parsing
> > fails. (Bug#39291)
>        ^^
> Please in the future leave 2 blanks between sentences, per our
> conventions.
>
>
> --- End Message ---