[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39528: closed ([PATCH 0/1] add tunctl)

From: GNU bug Tracking System
Subject: bug#39528: closed ([PATCH 0/1] add tunctl)
Date: Mon, 10 Feb 2020 00:04:02 +0000

Your message dated Mon, 10 Feb 2020 01:03:47 +0100
with message-id <address@hidden>
and subject line Re: [PATCH v4] Add tunctl
has caused the debbugs.gnu.org bug report #39528,
regarding [PATCH 0/1] add tunctl
to be marked as done.

(If you believe you have received this mail in error, please contact

39528: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39528
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH 0/1] add tunctl Date: Sun, 9 Feb 2020 16:44:43 +0100

the following message is a patch to add the tunctl package.

I took it straight from NixOS and converted to guix.

The NixOS package's license field was set to GPLv2, but
the single C source code file has only "GPL" mentionned,
I kept the NixOS choice, is that right ?

Te description is the same as the synopsis, as I didn't know
what I could add. Looks straightforward enough for me...

I passed the C code through clang-7 scan-build, it reported
nothing worth changing IMHO.

Please advise if any change needs to be done


Vincent Legoll

--- End Message ---
--- Begin Message --- Subject: Re: [PATCH v4] Add tunctl Date: Mon, 10 Feb 2020 01:03:47 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Vincent Legoll <address@hidden> writes:

> thanks for your input, this version incorporates your feedback,
> with a s/is/are/ and a capitalized first word of description.

Almost good! :)

I removed the (mkdir-p bin), not necessary with `install-file', changed
the commit message so it follows Guix conventions, and fixed the URI of
the package.

Applied. Thank you!

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]