--- Begin Message ---
Subject: |
[SHEPHERD] [PATCH] build: Adjust clean targets. |
Date: |
Thu, 20 Feb 2020 17:42:21 +0200 |
Makefile.am: Add man pages to the 'make clean' target.
---
Currently 'man shepherd' shows version 0.6.1, 'man herd' 0.6.0, 'man
halt' and 'man reboot' 0.3.2. With this patch these 4 manpages are added
to the 'make clean' list and are deleted. The manpage creation works as
expected.
---
Makefile.am | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 9a1f019..8cf98d6 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2,6 +2,7 @@
# Copyright © 2002, 2003 Wolfgang Jährling <address@hidden>
# Copyright © 2013, 2014, 2015, 2016, 2018, 2019 Ludovic Courtès
<address@hidden>
# Copyright © 2018 Carlo Zancanaro <address@hidden>
+# Copyright © 2020 Efraim Flashner <address@hidden>
#
# This file is part of the GNU Shepherd.
#
@@ -122,6 +123,8 @@ doc/%.8: modules/shepherd/scripts/%.scm
dist_man1_MANS = doc/shepherd.1 doc/herd.1
dist_man8_MANS = doc/halt.8 doc/reboot.8
+CLEANFILES += $(dist_man1_MANS) $(dist_man8_MANS)
+
# Things not automatically included in the distribution.
EXTRA_DIST += \
build-aux/config.rpath \
--
2.25.1
--- End Message ---
--- Begin Message ---
Subject: |
Re: [bug#39694] [SHEPHERD] [PATCH] build: Adjust clean targets. |
Date: |
Fri, 06 Mar 2020 12:10:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi Efraim,
Efraim Flashner <address@hidden> skribis:
> Makefile.am: Add man pages to the 'make clean' target.
> ---
> Currently 'man shepherd' shows version 0.6.1, 'man herd' 0.6.0, 'man
> halt' and 'man reboot' 0.3.2. With this patch these 4 manpages are added
> to the 'make clean' list and are deleted. The manpage creation works as
> expected.
[...]
> +CLEANFILES += $(dist_man1_MANS) $(dist_man8_MANS)
This would remove man pages upon “make clean”, whereas they should only
be removed upon “make distclean”, per GNU conventions.
I went with a different fix in Shepherd commit
f32a2ff8ad329f224b2f693ad7e9fefac142a459.
Thank you!
Ludo’.
--- End Message ---