emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40168: closed ([PATCH] )


From: GNU bug Tracking System
Subject: bug#40168: closed ([PATCH] )
Date: Sat, 21 Mar 2020 22:40:02 +0000

Your message dated Sat, 21 Mar 2020 23:39:12 +0100
with message-id <address@hidden>
and subject line Re: [bug#40168] [PATCH]
has caused the debbugs.gnu.org bug report #40168,
regarding [PATCH] 
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
40168: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40168
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] Date: Sat, 21 Mar 2020 18:02:57 +0100
Hi,

I've improved the packaging for clipmenu in
gnu/packages/xdisorg.scm. Please give feedback.

I found that my usage of wrap-script is very verbose. Is there a simpler
way?

Thank you

Damien Cassou (3):
  * gnu/packages/xdisorg.scm (clipmenu): Re-indent
  * gnu/packages/xdisorg.scm (clipnotify): Add a comment
  gnu: clipmenu: Improve the package definition

 gnu/packages/xdisorg.scm | 125 ++++++++++++++++++++++-----------------
 1 file changed, 72 insertions(+), 53 deletions(-)

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Attachment: 0001-gnu-packages-xdisorg.scm-clipmenu-Re-indent.patch
Description: Text Data

Attachment: 0002-gnu-packages-xdisorg.scm-clipnotify-Add-a-comment.patch
Description: Text Data

Attachment: 0003-gnu-clipmenu-Improve-the-package-definition.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: [bug#40168] [PATCH] Date: Sat, 21 Mar 2020 23:39:12 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Hi Damien,

Damien Cassou <address@hidden> skribis:

> Damien Cassou (3):
>   * gnu/packages/xdisorg.scm (clipmenu): Re-indent
>   * gnu/packages/xdisorg.scm (clipnotify): Add a comment
>   gnu: clipmenu: Improve the package definition

Applied!

I added a subject line to the commit logs.  For the last patch I
adjusted the shebang substitute:

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index f7c4668bf8..facd63ab53 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -2204,8 +2204,8 @@ tools to complement clipnotify.")
                  #t)))
            (add-after 'install 'wrap-script
              (lambda* (#:key inputs outputs #:allow-other-keys)
-               (let* ((out (assoc-ref outputs "out"))
-                      (clipnotify (assoc-ref inputs "clipnotify"))
+               (let* ((out               (assoc-ref outputs "out"))
+                      (clipnotify        (assoc-ref inputs "clipnotify"))
                       (coreutils-minimal (assoc-ref inputs 
"coreutils-minimal"))
                       (gawk              (assoc-ref inputs "gawk"))
                       (util-linux        (assoc-ref inputs "util-linux"))
@@ -2227,7 +2227,7 @@ tools to complement clipnotify.")
                ;; file writes this string to a temporary file):
                (substitute* "tests/test-clipmenu"
                  (("#!/usr/bin/env bash")
-                  (which "bash")))
+                  (string-append "#!" (which "bash"))))
                (invoke "tests/test-clipmenu")
                #t)))))
       (inputs
Thanks!

Ludo’.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]