emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40668: closed ([PATCH] installer: Fix backtrace display.)


From: GNU bug Tracking System
Subject: bug#40668: closed ([PATCH] installer: Fix backtrace display.)
Date: Sat, 18 Apr 2020 15:47:02 +0000

Your message dated Sat, 18 Apr 2020 17:46:30 +0200
with message-id <address@hidden>
and subject line Re: [bug#40668] [PATCH] installer: Fix backtrace display.
has caused the debbugs.gnu.org bug report #40668,
regarding [PATCH] installer: Fix backtrace display.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
40668: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40668
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] installer: Fix backtrace display. Date: Thu, 16 Apr 2020 19:33:54 +0200
The 'syslog' macro cannot be resolved in the pre-unwind-handler
context. Failed to resolve 'syslog' in this context resulted in the swallowing
of all installation errors.

Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.

* gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
in the pre-unwind-handler.
---

Hello,

Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
this means that every error happening in the 1.1.0 release will result in an
installer restart, without any error information reporting. 

Thanks,

Mathieu

 gnu/installer.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/installer.scm b/gnu/installer.scm
index 1051ee1e5f..eba8a7d428 100644
--- a/gnu/installer.scm
+++ b/gnu/installer.scm
@@ -436,8 +436,9 @@ selected keymap."
                      #f)))
                 (const #f)
                 (lambda (key . args)
-                  (syslog "crashing due to uncaught exception: ~s ~s~%"
-                          key args)
+                  ((@@ (gnu installer utils) syslog)
+                   "crashing due to uncaught exception: ~s ~s~%"
+                   key args)
                   (let ((error-file "/tmp/last-installer-error"))
                     (call-with-output-file error-file
                       (lambda (port)
-- 
2.26.0




--- End Message ---
--- Begin Message --- Subject: Re: [bug#40668] [PATCH] installer: Fix backtrace display. Date: Sat, 18 Apr 2020 17:46:30 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Hey,

> Please add (gnu installer utils) to the list of use-modules.
> ‘@@’ should only be used in extreme situations.

Fixed and pushed!

Thanks,

Mathieu


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]