bug#40829: closed ([core-updates] pdfpc-4.3.4 fails to build)

[GNU bug Tracking System]

Your message dated Fri, 24 Apr 2020 23:26:17 +0200
with message-id <address@hidden>
and subject line Re: bug#40829: [core-updates] pdfpc-4.3.4 fails to build
has caused the debbugs.gnu.org bug report #40829,
regarding [core-updates] pdfpc-4.3.4 fails to build
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
40829: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40829
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [core-updates] pdfpc-4.3.4 fails to build
>
>
>
>
> Date: 
>
> Fri, 24 Apr 2020 15:58:26 -0400 (EDT)
>
>
>
>
> User-agent: 
>
> Alpine 2.20 (DEB 67 2015-01-07)
>
>
>
>
> Hi Guix,
>
> Currently, pdfpc on core-updates fails to build with:
>
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/action/action_mapping.vala:51.9-51.28:
>  error: Creation method of abstract class cannot be public.
>         public ActionMapping() {
>         ^^^^^^^^^^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/drawings/storage.vala:38.9-38.19:
>  error: Creation method of abstract class cannot be public.
>         public Base(Metadata.Pdf metadata) {
>         ^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/renderer/cache/base.vala:40.9-40.19:
>  error: Creation method of abstract class cannot be public.
>         public Base(Metadata.Pdf metadata) {
>         ^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/timer_label.vala:98.9-98.25:
>  error: Creation method of abstract class cannot be public.
>         public TimerLabel(PresentationController controller, time_t start_time 
> = 0) {
>         ^^^^^^^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/view/behaviour/base.vala:44.9-44.19:
>  error: Creation method of abstract class cannot be public.
>         public Base() {
>         ^^^^^^^^^^^
>
> Upgrading to the latest release, 4.4.0, solves the problem. I have 
> prepared the following patch against core-updates that does that.
>
> Best,
> Jack
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#40829: [core-updates] pdfpc-4.3.4 fails to build Date: Fri, 24 Apr 2020 23:26:17 +0200 User-agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu)

Jack Hill <address@hidden> writes:

> Hi Guix,
>
> Currently, pdfpc on core-updates fails to build with:
>
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/action/action_mapping.vala:51.9-51.28:
>  error: Creation method of abstract class cannot be public.
>          public ActionMapping() {
>          ^^^^^^^^^^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/drawings/storage.vala:38.9-38.19:
>  error: Creation method of abstract class cannot be public.
>          public Base(Metadata.Pdf metadata) {
>          ^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/renderer/cache/base.vala:40.9-40.19:
>  error: Creation method of abstract class cannot be public.
>          public Base(Metadata.Pdf metadata) {
>          ^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/timer_label.vala:98.9-98.25:
>  error: Creation method of abstract class cannot be public.
>          public TimerLabel(PresentationController controller, time_t 
> start_time = 0) {
>          ^^^^^^^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/view/behaviour/base.vala:44.9-44.19:
>  error: Creation method of abstract class cannot be public.
>          public Base() {
>          ^^^^^^^^^^^
>
> Upgrading to the latest release, 4.4.0, solves the problem. I have 
> prepared the following patch against core-updates that does that.

Thanks!  I pushed the patch to the "master" branch: it will land on
"core-updates" shortly.

signature.asc
Description: PGP signature

--- End Message ---