bug#40812: closed ([PATCH] gnu: herbstluftwm: update to 0.8.1)

[GNU bug Tracking System]

Your message dated Mon, 27 Apr 2020 18:08:14 +0200
with message-id <20200427160814.plpxyggb6gjbvbtu@gravity>
and subject line Re: [PATCH] gnu: herbstluftwm: update to 0.8.1
has caused the debbugs.gnu.org bug report #40812,
regarding [PATCH] gnu: herbstluftwm: update to 0.8.1
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
40812: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40812
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: herbstluftwm: update to 0.8.1
>
>
>
>
> Date: 
>
> Fri, 24 Apr 2020 19:21:06 +1200
>
>
>
>
> ---
>  gnu/packages/wm.scm | 34 ++++++++++++++++------------------
>  1 file changed, 16 insertions(+), 18 deletions(-)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 82f11d13fa..cd26607b27 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -149,7 +149,7 @@ the leaves of a full binary tree.")
>  (define-public herbstluftwm
>    (package
>      (name "herbstluftwm")
> -    (version "0.7.2")
> +    (version "0.8.1")
>      (source
>       (origin
>         (method url-fetch)
> @@ -157,9 +157,9 @@ the leaves of a full binary tree.")
>                             version ".tar.gz"))
>         (sha256
>          (base32
> -         "1kc18aj9j3nfz6fj4qxg9s3gg4jvn6kzi3ii24hfm0vqdpy17xnz"))
> +         "0c1lf82z6a56g8asin91cmqhzk3anw0xwc44b31bpjixadmns57y"))
>         (file-name (string-append "herbstluftwm-" version ".tar.gz"))))
> -    (build-system gnu-build-system)
> +    (build-system cmake-build-system)
>      (inputs
>       `(("dzen"        ,dzen)
>         ("dmenu"       ,dmenu)
> @@ -169,13 +169,21 @@ the leaves of a full binary tree.")
>         ("xsetroot"    ,xsetroot)
>         ("libx11"      ,libx11)
>         ("libxext"     ,libxext)
> -       ("libxinerama" ,libxinerama)))
> +       ("libxrandr"   ,libxrandr)
> +       ("libxinerama" ,libxinerama)
> +       ("bash"        ,bash)))
>      (native-inputs
> -     `(("pkg-config" ,pkg-config)))
> +     `(("pkg-config" ,pkg-config)
> +       ("asciidoc"   ,asciidoc)))
>      (arguments
> -     '(#:phases
> +     '(#:tests? #f
> +       #:configure-flags
> +       (let ((out (assoc-ref %outputs "out")))
> +         (list "-DCC=gcc"
> +               (string-append "-DCMAKE_INSTALL_SYSCONF_PREFIX=" out "/etc")
> +               (string-append "-DBASHCOMPLETIONDIR=" out 
> "/etc/bash_completion.d")))
> +       #:phases
>         (modify-phases %standard-phases
> -         (delete 'configure)            ; no configure script
>           (add-after 'install 'install-xsession
>             (lambda* (#:key outputs #:allow-other-keys)
>               (let* ((out (assoc-ref outputs "out"))
> @@ -190,17 +198,7 @@ the leaves of a full binary tree.")
>                       Comment=Manual tiling window manager~@
>                       Exec=~a/bin/herbstluftwm~@
>                       Type=XSession~%" out)))
> -               #t))))
> -       #:tests? #f
> -       #:make-flags
> -       (let ((out (assoc-ref %outputs "out")))
> -         (list "CC=gcc"
> -               (string-append "PREFIX=''")
> -               (string-append "DESTDIR=" out)
> -               (string-append "FISHCOMPLETIONDIR="
> -                              "/share/fish/vendor_completions.d")
> -               (string-append "BASHCOMPLETIONDIR=" out
> -                              "/etc/bash_completion.d")))))
> +               #t))))))
>      (synopsis "Tiling window manager for X11")
>      (description "herbstluftwm is a manual tiling window manager for X11 using
>  Xlib and GLib.  Its main features are:
> -- 
> 2.26.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH] gnu: herbstluftwm: update to 0.8.1 Date: Mon, 27 Apr 2020 18:08:14 +0200

On Tue, Apr 28, 2020 at 03:25:26AM +1200, Boris A. Dekshteyn wrote:
> Jakub Kądziołka <address@hidden> writes:
> 
> > In Guix, the `inputs' field only affects packages available at build
> > time. Runtime dependencies are inferred from the package hashes stored
> > in build artifacts.
> 
> Thanks for clarifying.

Thanks for your updated patch! I took the liberty to rearrange the added
inputs a bit to preserve the alphabetical sort and added a copyright
line for you, then pushed to master as commit
138896e1ea4d0ba420d04bff067692fecf93a613.

Cheers!

signature.asc
Description: PGP signature

--- End Message ---