bug#40937: closed ([PATCH] services: syslog: Simplify 'start' method.)

[GNU bug Tracking System]

Your message dated Fri, 01 May 2020 23:59:07 +0200
with message-id <address@hidden>
and subject line Re: [bug#40937] [PATCH] services: syslog: Simplify 'start' 
method.
has caused the debbugs.gnu.org bug report #40937,
regarding [PATCH] services: syslog: Simplify 'start' method.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
40937: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40937
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services: syslog: Simplify 'start' method.
>
>
>
>
> Date: 
>
> Tue, 28 Apr 2020 15:22:58 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hey Guix,
>
> This patch simplifies the 'start' method of 'syslog-service-type' by
> setting the umask using the new #:file-creation-mask parameter of
> 'make-forkexec-constructor', which was introduced in version 0.8.0 of
> the Shepherd, instead of wrapping the constructor in a lambda.
>
> Regards,
>
> Diego
>
> >From 5ac4af21427afb8ef498b0de7151f116a6f7d9eb Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <address@hidden>
> Date: Tue, 28 Apr 2020 13:31:54 +0200
> Subject: [PATCH] services: syslog: Simplify 'start' method.
>
> This is a followup to d7113bb655ff80a868a9e624c913f9d23e6c63ad and
> e3358a831e7d5d9e8dc614340e49ea5aeb11a7ff.
>
> * gnu/services/base.scm (syslog-service-type): Change 'start' method to set
>   umask using the #:file-creation-mask parameter of
>   'make-forkexec-constructor' introduced in version 0.8.0 of the Shepherd.
> ---
>  gnu/services/base.scm | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/gnu/services/base.scm b/gnu/services/base.scm
> index 2913478e4a..0f119cc2f9 100644
> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -1316,17 +1316,13 @@ Service Switch}, for an example."
>        (documentation "Run the syslog daemon (syslogd).")
>        (provision '(syslogd))
>        (requirement '(user-processes))
> -      (start #~(let ((spawn (make-forkexec-constructor
> -                             (list #$(syslog-configuration-syslogd config)
> -                                   "--rcfile"
> -                                   #$(syslog-configuration-config-file config))
> -                             #:pid-file "/var/run/syslog.pid")))
> -                 (lambda ()
> -                   ;; Set the umask such that file permissions are #o640.
> -                   (let ((mask (umask #o137))
> -                         (pid  (spawn)))
> -                     (umask mask)
> -                     pid))))
> +      (start #~(make-forkexec-constructor
> +                (list #$(syslog-configuration-syslogd config)
> +                      "--rcfile"
> +                      #$(syslog-configuration-config-file config))
> +                ;; Set the umask such that file permissions are #o640.
> +                #:file-creation-mask #o137
> +                #:pid-file "/var/run/syslog.pid"))
>        (stop #~(make-kill-destructor))))))
>  
>  ;; Snippet adapted from the GNU inetutils manual.
> -- 
> 2.26.0
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#40937] [PATCH] services: syslog: Simplify 'start' method.
>
>
>
>
> Date: 
>
> Fri, 01 May 2020 23:59:07 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hi,
>
> Diego Nicola Barbato <address@hidden> skribis:
>
> >>From 5ac4af21427afb8ef498b0de7151f116a6f7d9eb Mon Sep 17 00:00:00 2001
> > From: Diego Nicola Barbato <address@hidden>
> > Date: Tue, 28 Apr 2020 13:31:54 +0200
> > Subject: [PATCH] services: syslog: Simplify 'start' method.
> >
> > This is a followup to d7113bb655ff80a868a9e624c913f9d23e6c63ad and
> > e3358a831e7d5d9e8dc614340e49ea5aeb11a7ff.
> >
> > * gnu/services/base.scm (syslog-service-type): Change 'start' method to set
> >   umask using the #:file-creation-mask parameter of
> >   'make-forkexec-constructor' introduced in version 0.8.0 of the Shepherd.
>
> Perfect!  Applied, thanks.
>
> Ludo’.
>
>
> --- End Message ---