--- Begin Message ---
|
Subject: |
[PATCH] gnu: add j4-dmenu-desktop |
|
Date: |
Tue, 28 Apr 2020 11:37:05 +0100 |
---
gnu/packages/xdisorg.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index bc2c9c4622..02997dcbf1 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -35,6 +35,7 @@
;;; Copyright © 2020 Brice Waegeneire <address@hidden>
;;; Copyright © 2020 Damien Cassou <address@hidden>
;;; Copyright © 2020 John Soo <address@hidden>
+;;; Copyright © 2020 Alex McGrath <address@hidden>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2286,3 +2287,25 @@ to find all available clips and launches @command{dmenu}
(or @command{rofi},
depending on the value of @code{CM_LAUNCHER}) to let the user select a clip.
After selection, the clip is put onto the PRIMARY and CLIPBOARD X selections.")
(license license:public-domain))))
+
+(define-public j4-dmenu-desktop
+ (package
+ (name "j4-dmenu-desktop")
+ (version "2.17")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/enkore/j4-dmenu-desktop.git";)
+ (commit (string-append "r" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off"
"-DWITH_TESTS=off")
+ #:tests? #f)) ;; tests fetch an external git repo
+ (synopsis "A fast desktop menu")
+ (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's
purpose is to find desktop files and offer you a menu to start an application
using dmenu.")
+ (home-page "https://github.com/enkore/j4-dmenu-desktop";)
+ (license license:gpl3+)))
--
2.26.1
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop |
|
Date: |
Mon, 04 May 2020 16:33:05 +0200 |
|
User-agent: |
Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) |
"Alex McGrath" <address@hidden> writes:
> Howdy,
>
> I think I've addressed the comments (ran guix lint etc) and I enabled all the
> tests except for one, as it checks for a directory that doesnt exist on guix
> and fails as a result
Excellent, LGTM!
I've applied the patch with minor adjustments (removed redundant
#:tests? #t, and formatted description with @file and @command markup
where appropriate).
Pushed in c65e243463c704698288bad787cd6f5292280bba, thanks!
signature.asc
Description: PGP signature
--- End Message ---