emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#41167: closed (Julia: fix current patches, upgrade to 1.4.1)


From: GNU bug Tracking System
Subject: bug#41167: closed (Julia: fix current patches, upgrade to 1.4.1)
Date: Tue, 12 May 2020 13:38:02 +0000

Your message dated Tue, 12 May 2020 15:36:51 +0200
with message-id <address@hidden>
and subject line Re: [bug#41167] V2 Re: [bug#41167] [PATCH 5/5] gnu: Add 
julia-compat.
has caused the debbugs.gnu.org bug report #41167,
regarding Julia: fix current patches, upgrade to 1.4.1
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
41167: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41167
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Julia: fix current patches, upgrade to 1.4.1 Date: Sun, 10 May 2020 10:07:03 +0200
Hello guix!

In the following patches I:
- fixed current julia: I don't know how, the patch-url is missing
  ".patch" at the end, leading to a 404.  Don't know how it can build
  right now
- fixed the julia-SOURCE_DATE_EPOCH-mtime.patch: It's now a meta-patch,
  that creates the right patch file, so the current julia version is not
  patched, and precompile cache of packages installed with guix is
  broken.  Still no julia-package is in guix, that's why it went
  unnoticed
- Add libwhich (I added it to julia.scm but probably there's a better
  place for it)
- Update julia to latest release, v1.4.1.  I was finally able to
  unbundle the last pieces of bundled software (libwhich).  Now julia
  is based on llvm-8 (previously on llvm-6) and I measuread a speedup of
  ~17x on precompile times
- Add the first julia package, julia-compat.  If everything is fine, I'll
  then submit a big series of packages

Feedback welcome!

Nicolò



--- End Message ---
--- Begin Message --- Subject: Re: [bug#41167] V2 Re: [bug#41167] [PATCH 5/5] gnu: Add julia-compat. Date: Tue, 12 May 2020 15:36:51 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Hi Nicolò,

Nicolò Balzarotti <address@hidden> skribis:

>> Hello!
>>
>> nixo <address@hidden> skribis:
>>
>>> * julia-xyz.scm: New file.
>>> * local.mk: Add julia-xyz.scm to it.
>>> * julia-xyz.scm (julia-compat): New variable.
>>
>> Please spell out file names; you can also remove the last line, not
>> needed here since it’s a new file.
>>
>>> --- /dev/null
>>> +++ b/gnu/packages/julia-xyz.scm
>>> @@ -0,0 +1,27 @@
>>> +(define-module (gnu packages julia-xyz)
>>
>> Could you add the license/copyright header and resend this one?
>>
>> I’ll see if I can apply the whole series and build it tomorrow.
>>
> Prepare for a long build time!  Running tests takes like 4 hours.

Ouch, indeed.  It went fine though!

I pushed the whole series.  Note that I modified the patch-adjusting
patch to preserve the comment that was originally there.

Nitpick: for future patches, I recommend avoiding “Fix …” in the subject
line, unless (1) there’s a bug report and the commit log links to it, or
(2) the commit log explains what’s being fixed.  (It wasn’t clear to me
whether the first two patches were “fixing” something that didn’t work
at all, and to what extent.)

Anyway, thumbs up for the upgrade!  \o/

Thanks,
Ludo’.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]