bug#41685: closed ([PATCH] doc: Add note to 'udisks-service'.)

[GNU bug Tracking System]

Your message dated Tue, 09 Jun 2020 10:35:43 +0200
with message-id <87eeqohc0w.fsf@waegenei.re>
and subject line Re: [bug#41685] [PATCH] doc: Add note to 'udisks-service'.
has caused the debbugs.gnu.org bug report #41685,
regarding [PATCH] doc: Add note to 'udisks-service'.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41685: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41685
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] doc: Add note to 'udisks-service'.
>
>
>
>
> Date: 
>
> Wed,  3 Jun 2020 13:52:18 +0200
>
>
>
>
> * doc/guix.texi (Desktop Services): Specify how to add file-systems
> utilities to 'udisks-service'.
> ---
>  doc/guix.texi | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 8335373145..12ed7923b3 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -16631,9 +16631,14 @@ Possible values are:
>  
>  @deffn {Scheme Procedure} udisks-service [#:udisks @var{udisks}]
>  Return a service for @uref{https://udisks.freedesktop.org/docs/latest/,
> -UDisks}, a @dfn{disk management} daemon that provides user interfaces with
> -notifications and ways to mount/unmount disks.  Programs that talk to UDisks
> -include the @command{udisksctl} command, part of UDisks, and GNOME Disks.
> +UDisks}, a @dfn{disk management} daemon that provides user interfaces
> +with notifications and ways to mount/unmount disks.  Programs that talk
> +to UDisks include the @command{udisksctl} command, part of UDisks, and
> +GNOME Disks.  Note that Udisks rely on the @command{mount} command, so
> +it will only be able to use the file-system utilities which are
> +installed in the system profile.  For example if you want to be able to
> +mount NTFS file-systems in read and write fashion, you'll need to have
> +@code{ntfs-3g} installed system-wide.
>  @end deffn
>  
>  @deffn {Scheme Variable} colord-service-type
> -- 
> 2.26.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#41685] [PATCH] doc: Add note to 'udisks-service'.
>
>
>
>
> Date: 
>
> Tue, 09 Jun 2020 10:35:43 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
>
>
>
>
> Hi Ludo',
>
> Thank you for the review.
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > Hi!
> >
> > Brice Waegeneire <brice@waegenei.re> skribis:
> >
> >> * doc/guix.texi (Desktop Services): Specify how to add file-systems
> >> utilities to 'udisks-service'.
> >
> > [...]
> >
> >> +UDisks}, a @dfn{disk management} daemon that provides user interfaces
> >> +with notifications and ways to mount/unmount disks.  Programs that talk
> >> +to UDisks include the @command{udisksctl} command, part of UDisks, and
> >> +GNOME Disks.  Note that Udisks rely on the @command{mount} command, so
> >
> > s/rely/relies/
> >
> >> +it will only be able to use the file-system utilities which are
> >
> > s/which are//
> >
> >> +installed in the system profile.  For example if you want to be able to
> >> +mount NTFS file-systems in read and write fashion, you'll need to have
> >> +@code{ntfs-3g} installed system-wide.
> >>  @end deffn
> >
> > LGTM!
> >
> > Thanks,
> > Ludo’.
> >
>
> Pushed as 1b5d26c967b17b635c88a094e010cd42a9afb220 with the 2 fixes you
> suggested.
>
> -Brice
>
>
> --- End Message ---