bug#41619: closed ([PATCH] Mark python-shell-virtualenv-root as safe local variable)

[GNU bug Tracking System]

Your message dated Sat, 13 Jun 2020 10:42:57 +0300
with message-id <83eeqj4dj2.fsf@gnu.org>
and subject line Re: bug#41619: [PATCH] Mark python-shell-virtualenv-root as 
safe local variable
has caused the debbugs.gnu.org bug report #41619,
regarding [PATCH] Mark python-shell-virtualenv-root as safe local variable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41619: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41619
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Mark python-shell-virtualenv-root as safe local variable
>
>
>
>
> Date: 
>
> Sat, 30 May 2020 22:31:09 +0200
>
>
>
>
> Hi,
>
> I was trying to work with python today and it required me to use a
> virtual environment. I noticed that python-mode already had some basic
> virtualenv facilites, and it all worked. The only thing that annoyed me
> was that I couldn't configure the setup to be properly persistent, since
> python-shell-virtualenv-root couldn't be set as a directory local
> variable.
>
> The commentary section mentions
>
> > ;; (setq python-shell-virtualenv-root "/path/to/env/")
>
> but I couldn't find any other details on how the mode expects me to set
> the variable.
>
> Therefore I patched the few lines, and it works great.
>
> >From 31beb4931ae7800e719ac470ba8bd14a977f765c Mon Sep 17 00:00:00 2001
> From: Philip K <philip@warpmail.net>
> Date: Sat, 30 May 2020 21:47:51 +0200
> Subject: [PATCH] Mark python-shell-virtualenv-root as safe for directories
>
> ---
>  lisp/progmodes/python.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
> index 1ca9f01963..f9537b4079 100644
> --- a/lisp/progmodes/python.el
> +++ b/lisp/progmodes/python.el
> @@ -2090,7 +2090,8 @@ python-shell-virtualenv-root
>  This variable, when set to a string, makes the environment to be
>  modified such that shells are started within the specified
>  virtualenv."
> -  :type '(choice (const nil) string)
> +  :type '(choice (const nil) directory)
> +  :safe #'file-directory-p
>    :group 'python)
>  
>  (defcustom python-shell-setup-codes nil
> -- 
> 2.26.2
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#41619: [PATCH] Mark python-shell-virtualenv-root as safe local variable
>
>
>
>
> Date: 
>
> Sat, 13 Jun 2020 10:42:57 +0300
>
>
>
>
> > From: "Philip K." <philip.kaludercic@fau.de>
> > Date: Sat, 30 May 2020 22:31:09 +0200
> > 
> > I was trying to work with python today and it required me to use a
> > virtual environment. I noticed that python-mode already had some basic
> > virtualenv facilites, and it all worked. The only thing that annoyed me
> > was that I couldn't configure the setup to be properly persistent, since
> > python-shell-virtualenv-root couldn't be set as a directory local
> > variable.
> > 
> > The commentary section mentions
> > 
> > > ;; (setq python-shell-virtualenv-root "/path/to/env/")
> > 
> > but I couldn't find any other details on how the mode expects me to set
> > the variable.
> > 
> > Therefore I patched the few lines, and it works great.
>
> Thanks, installed on the master branch.
>
> In the future please accompany your changes with a ChangeLog-style
> commit log entry; see CONTRIBUTE for the details.  (I added that for
> you in this case.)
>
>
> --- End Message ---