bug#41662: closed ([PATCH] gnu: zsh: Set default '$fpath'.)

[GNU bug Tracking System]

Your message dated Sun, 14 Jun 2020 15:33:38 +0200
with message-id <87r1uh7owd.fsf@waegenei.re>
and subject line Re: [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
has caused the debbugs.gnu.org bug report #41662,
regarding [PATCH] gnu: zsh: Set default '$fpath'.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41662: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41662
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: zsh: Set default '$fpath'.
>
>
>
>
> Date: 
>
> Tue,  2 Jun 2020 15:20:48 +0200
>
>
>
>
> * gnu/packages/shells.scm (zsh)[arguments]: Add configure-flags
> 'disable-site-dir' and 'enable-additional-fpath'.
> ---
>  gnu/packages/shells.scm | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
> index 74d08e02bc..250c6d5576 100644
> --- a/gnu/packages/shells.scm
> +++ b/gnu/packages/shells.scm
> @@ -441,8 +441,16 @@ history mechanism, job control and a C-like syntax.")
>                 (base32
>                  "09yyaadq738zlrnlh1hd3ycj1mv3q5hh4xl1ank70mjnqm6bbi6w"))))
>      (build-system gnu-build-system)
> -    (arguments `(#:configure-flags '("--with-tcsetpgrp" "--enable-pcre"
> -                                     "--enable-maildir-support")
> +    (arguments `(#:configure-flags
> +                 `("--with-tcsetpgrp"
> +                  "--enable-pcre"
> +                  "--enable-maildir-support"
> +                  ;; share/zsh/site-functions isn't populated
> +                  "--disable-site-fndir"
> +                  ,(string-append
> +                    "--enable-additional-fpath="
> +                    "/usr/local/share/zsh/site-functions," ; for foreign OS
> +                    "/run/current-system/profile/share/zsh/site-functions"))
>                   #:phases
>                   (modify-phases %standard-phases
>                     (add-before 'configure 'fix-sh
> -- 
> 2.26.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
>
>
>
>
> Date: 
>
> Sun, 14 Jun 2020 15:33:38 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
>
>
>
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > Brice Waegeneire <brice@waegenei.re> skribis:
> >
> >> On 2020-06-11 17:08, Ludovic Courtès wrote:
> >>>> +                  ,(string-append
> >>>> +                    "--enable-additional-fpath="
> >>>> +                    "/usr/local/share/zsh/site-functions," ; for
> >>>> foreign OS
> >>>> +
> >>>> "/run/current-system/profile/share/zsh/site-functions"))
> >>>
> >>> /usr/local seems arbitrary.  What if we omit it, will that break zsh on
> >>> foreign distros?
> >>
> >> I let it there because it's a default[0] and because it was already
> >> present
> >> in our current zsh package, you can test that with “zsh -df -c 'echo
> >> $fpath'”.
> >
> > OK, that makes sense to me.
>
> Pushed as 4f6e6c0442368ac3fd7e95f1fc264671d9182c00.
>
> - Brice
>
>
> --- End Message ---