bug#41977: closed (28.0.50; [PATCH]: eval-when-compile eshell in project.el)

[GNU bug Tracking System]

Your message dated Mon, 22 Jun 2020 01:52:15 +0300
with message-id <32e8aca2-efa7-76dd-db8c-dd8a80e12297@yandex.ru>
and subject line Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in 
project.el
has caused the debbugs.gnu.org bug report #41977,
regarding 28.0.50; [PATCH]: eval-when-compile eshell in project.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41977: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41977
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Date: Sun, 21 Jun 2020 11:33:06 +0000

Hi!

I saw a little too late that the latest patch to 'project-eshell' didn't
apply correctly when compiling emacs.  As such you would get old
behavior until you eval 'project-eshell'.

A quick fix as far as I can tell is the below patch.

Theo

0001-project.el-eval-when-compile-eshell.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
>
>
>
>
> Date: 
>
> Mon, 22 Jun 2020 01:52:15 +0300
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0
>
>
>
>
> On 21.06.2020 20:55, Basil L. Contovounesios wrote:
> > > You are absolutely correct, and TIL - thanks:)
> > >
> > > Below is another patch doing this. Works fine in emacs -Q
> > Thanks, LGTM.
>
> Thanks all!
>
> Pushed (after rephrasing the commit message in the imperative mood).
>
>
> --- End Message ---