bug#42489: closed ([PATCH] services: nix: Provide nix commands.)

[GNU bug Tracking System]

Your message dated Sat, 25 Jul 2020 12:33:19 +0300
with message-id <871rl0aqhs.fsf@gmail.com>
and subject line Re: [bug#42489] [PATCH] services: nix: Provide nix commands.
has caused the debbugs.gnu.org bug report #42489,
regarding [PATCH] services: nix: Provide nix commands.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42489: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42489
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services: nix: Provide nix commands.
>
>
>
>
> Date: 
>
> Thu, 23 Jul 2020 17:24:13 +0800
>
>
>
>
> * gnu/services/nix.scm (nix-service-type): Extend profile-service-type to
> provide nix commands.
> ---
>  gnu/services/nix.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/nix.scm b/gnu/services/nix.scm
> index 75b2df02dc..e73203c2c5 100644
> --- a/gnu/services/nix.scm
> +++ b/gnu/services/nix.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2019, 2020 Oleg Pykhalov <go.wigust@gmail.com>
> +;;; Copyright © 2020 Peng Mei Yu <i@pengmeiyu.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -134,7 +135,9 @@ GID."
>     (extensions
>      (list (service-extension shepherd-root-service-type nix-shepherd-service)
>            (service-extension account-service-type nix-accounts)
> -          (service-extension activation-service-type nix-activation)))
> +          (service-extension activation-service-type nix-activation)
> +          (service-extension profile-service-type
> +                             (compose list nix-configuration-package))))
>     (description "Run the Nix daemon.")
>     (default-value (nix-configuration))))
>  
> -- 
> 2.27.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#42489] [PATCH] services: nix: Provide nix commands. Date: Sat, 25 Jul 2020 12:33:19 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Peng Mei Yu <pengmeiyu@riseup.net> writes:

>> @@ -134,7 +135,9 @@ GID."
>>     (extensions
>>      (list (service-extension shepherd-root-service-type 
>> nix-shepherd-service)
>>            (service-extension account-service-type nix-accounts)
>> -          (service-extension activation-service-type nix-activation)))
>> +          (service-extension activation-service-type nix-activation)
>> +          (service-extension profile-service-type
>> +                             (compose list nix-configuration-package))))
>>     (description "Run the Nix daemon.")
>>     (default-value (nix-configuration))))
>
> The nix-service is useless without commands like nix, nix-env,
> nix-shell, etc.  I think it's a standard that a guix service should
> provide necessary commands in order to use that service.

Ah, good catch!  Pushed your changes to master.

Thanks again,
Oleg.

signature.asc
Description: PGP signature

--- End Message ---