[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23074: closed (25.1.50; X11: `use-fancy-splash-screens-p` erroneousl

From: GNU bug Tracking System
Subject: bug#23074: closed (25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil.)
Date: Sat, 15 Aug 2020 04:23:03 +0000

Your message dated Fri, 14 Aug 2020 21:22:16 -0700
with message-id 
and subject line Re: bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` 
erroneously returns nil.
has caused the debbugs.gnu.org bug report #23074,
regarding 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil.
to be marked as done.

(If you believe you have received this mail in error, please contact

23074: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23074
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil. Date: Sun, 20 Mar 2016 22:08:43 -0700
Emacs master branch built `--with-x --with-ns=no` with full image support on an 
OSX machine (10.6.8) does not display the Emacs logo on the Welcome screen 
because the final test of `use-fancy-splash-screen-p` returns nil.  If we use 
17 instead of 19, the test returns `t` and the Emacs logo is displayed.

I would suggest using a better test like `one-window-p`, because 19 is too big.

    (defun use-fancy-splash-screens-p ()
      "Return t if fancy splash screens should be used."
      (when (and (display-graphic-p)
                 (or (and (display-color-p)
              (image-type-available-p 'xpm))
                     (image-type-available-p 'pbm)))
        (let ((frame (fancy-splash-frame)))
          (when frame
      (let* ((img (create-image (fancy-splash-image-file)))
             (image-height (and img (cdr (image-size img nil frame))))
             ;; We test frame-height so that, if the frame is split
             ;; by displaying a warning, that doesn't cause the normal
             ;; splash screen to be used.
             (frame-height (1- (frame-height frame))))
       ;; The original value added to the `image-height' for the test was 19; 
       ;; that causes the test to fail on X11 by about 1.5 -- so use 17 instead.
        (> frame-height (+ image-height 17)))))))



--- End Message ---
--- Begin Message --- Subject: Re: bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil. Date: Fri, 14 Aug 2020 21:22:16 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
Eli Zaretskii <eliz@gnu.org> writes:

> Ping!  I'd like to fix this problem for Emacs 25.1, if possible.
>> Date: Sat, 09 Apr 2016 10:53:02 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: 23074@debbugs.gnu.org
>> > Date:  Fri, 08 Apr 2016 23:48:13 -0700
>> > From:  Keith David Bershatsky <esq@lawlist.com>
>> > Cc:  23074@debbugs.gnu.org
>> >
>> > In all four (4) cases tested this evening with the current emacs-25 branch 
>> > (April 8, 2016), the `splash.svg` image is used and it has the same 
>> > dimensions in all four situations tested:  (41.625 . 15.533333333333333).
>> Thanks.  This means the initial frame needs to be enlarged by one more
>> line.
>> However, I wonder whether this is what all OS X users see, or just
>> something specific to your system.  Can someone else please repeat
>> these experiments on OS X and report the results?  John?  Anyone?
>> Here's the recipe to be evaluated in *scratch* in "emacs -Q":
>>   (let* ((img (create-image (fancy-splash-image-file)))
>>       (image-height (and img (cdr (image-size img nil)))))
>>     (message "%s" image-height))
>> > I have not experimented with removing svg support while trying to maintain 
>> > support for other possible image types -- e.g., splash.pbm, splash.png or 
>> > splash.xpm.
>> I don't think this matters, all the images will have the same size.

More information was requested, but none was given within 4 years, so
I'm closing this bug.  If this is still an issue, please reply to this
email (use "Reply to all" in your email client) and we can reopen the
bug report.

Best regards,
Stefan Kangas

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]