bug#43108: closed ([PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.)

[GNU bug Tracking System]

Your message dated Tue, 01 Sep 2020 21:27:50 +0200
with message-id <87wo1dthzd.fsf@gnu.org>
and subject line Re: [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test 
failing on Emacs 27.1.
has caused the debbugs.gnu.org bug report #43108,
regarding [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
43108: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43108
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.
>
>
>
>
> Date: 
>
> Sun, 30 Aug 2020 09:50:25 +0200
>
>
>
>
> * gnu/packages/emacs-xyz.scm (emacs-elisp-refs)[arguments]:
> Add phase to disable failing test "elisp-refs-next-match" on emacs27.
> ---
> My ert-runner fu is not good enough for a better hack. I tried
> '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it
> skipped all tests then.
>
>  gnu/packages/emacs-xyz.scm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index c6d95d9b83..cfc728b53e 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -14825,7 +14825,17 @@ continue.")
>         ("emacs-undercover" ,emacs-undercover)))
>      (arguments
>       `(#:tests? #t
> -       #:test-command '("ert-runner")))
> +       #:test-command '("ert-runner")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'disable-refs-next-match-test
> +           ;; Hack to disable the failing test for emacs27
> +           ;; https://github.com/Wilfred/elisp-refs/issues/29
> +           (lambda _
> +             (substitute* "test/unit-test.el"
> +               (("ert-deftest elisp-refs-next-match")
> +                "defun elisp-refs-next-match"))
> +             #t)))))
>      (home-page "https://github.com/Wilfred/elisp-refs";)
>      (synopsis "Find callers of elisp functions or macros")
>      (description "Find references to functions, macros or variables.  Unlike a
> -- 
> 2.28.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.
>
>
>
>
> Date: 
>
> Tue, 01 Sep 2020 21:27:50 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hello Michael,
>
> > My ert-runner fu is not good enough for a better hack. I tried
> > '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it
> > skipped all tests then.
>
> Well your hack seems to work fine :) Pushed as
> a73ccefe315cd16e9d0b31a00bbd61e6cc3042f5.
>
> Thanks,
>
> Mathieu
>
>
> --- End Message ---