bug#43204: closed ([PATCH] gnu: taglib: Propagate zlib.)

[GNU bug Tracking System]

Your message dated Tue, 08 Sep 2020 00:55:25 +0200
with message-id <874ko9fb8i.fsf@gnu.org>
and subject line Re: [bug#43204] [PATCH] gnu: taglib: Propagate zlib.
has caused the debbugs.gnu.org bug report #43204,
regarding [PATCH] gnu: taglib: Propagate zlib.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
43204: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43204
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: taglib: Propagate zlib.
>
>
>
>
> Date: 
>
> Fri,  4 Sep 2020 17:38:24 +0200
>
>
>
>
> * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs].
> ---
> It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz
> according to the installed pkg-config.
>
> I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib,
> (I guess, all revdeps of taglib that don't have zlib as an input have that 
> problem)
>
>  gnu/packages/mp3.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 7ee009df74..8ea282be97 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -175,7 +175,7 @@ a highly stable and efficient implementation.")
>      (arguments
>        '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on.
>          #:configure-flags (list "-DBUILD_SHARED_LIBS=ON")))
> -    (inputs `(("zlib" ,zlib)))
> +    (propagated-inputs `(("zlib" ,zlib)))
>      (home-page "https://taglib.org";)
>      (synopsis "Library to access audio file meta-data")
>      (description
> -- 
> 2.28.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#43204] [PATCH] gnu: taglib: Propagate zlib.
>
>
>
>
> Date: 
>
> Tue, 08 Sep 2020 00:55:25 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>
> > Ludovic Courtès writes:
>
> [...]
>
> >> commit d8124a707602980556fd33c7dbf9f7483fe1d0df
> >> Author: Ludovic Courtès <ludo@gnu.org>
> >> Date:   Mon Sep 7 09:56:08 2020 +0200
> >>
> >>     gnu: taglib: 'taglib-config --libs' shows -L flag for zlib.
> >>     
> >>     Fixes compilation of emacs-emms-print-metadata.
> >>     
> >>     * gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases.
> >
> > LGTM!
> >
> > I was originally thinking we could just drop the `-lz`, since it
> > /should/ only be needed for people who statically link with taglib, and
> > we only ship shared libs. But actually, it's probably safer to follow
> > what upstream is doing.
>
> Yeah.  Pushed as d2a7114e0b46fccad1e02e301c58a5124f361c5c, thanks!
>
> Ludo’.
>
>
> --- End Message ---