bug#43348: closed (Profanity)

[GNU bug Tracking System]

Your message dated Sun, 13 Sep 2020 11:54:26 +0200
with message-id <20200913115426.0a0bba06@scratchpost.org>
and subject line Re: Profanity
has caused the debbugs.gnu.org bug report #43348,
regarding Profanity
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
43348: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43348
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: Profanity Date: Fri, 11 Sep 2020 15:52:23 -0400

Hello Guix!

Please find the attached patch to make changed to Profanity.

Regards,
RG.

0004-gnu-profanity-Revise-package-definition.patch
Description: Text Data

signature.asc
Description: OpenPGP digital signature

--- End Message ---

--- Begin Message --- Subject: Re: Profanity Date: Sun, 13 Sep 2020 11:54:26 +0200

Hi RG,

On Sun, 13 Sep 2020 05:12:04 -0400
Raghav Gururajan <raghavgururajan@disroot.org> wrote:

> > I still don't get it why python-wrapper is a *native* input in order to 
> > support
> > Python plugins.  That would mean the Python plugins are only used at build 
> > time
> > and not used at runtime.  Is that correct?  
> 
> As far as I understand, the package uses the python binary to compile a
> component, which will be used to add/remove python plugins.

I doubt it.

$ ./pre-inst-env guix gc --references `./pre-inst-env guix build profanity`
[...]
/gnu/store/09a5iq080g9b641jyl363dr5jkkvnhcn-python-3.8.2

So it keeps a runtime reference to python.  I suspect it just embeds a Python
interpreter.  So it should probably be a regular input.
The question is whether the plugins written in Python actually work or not.
Usually they require some extra PYTHONPATH or whatever setting in order to
find stuff.  Just raw Python is often not enough.

But we'll see.

Moved python-wrapper to regular input.

Pushed patchset to master.

I edited the commit messages not to include internal rationale like that that
change is the correct change (for glib-or-gtk-build-system) or whatever.

If we need that it should go in the source code as a comment--where it can
be easily seen.

pgpACXmTxUHK7.pgp
Description: OpenPGP digital signature

--- End Message ---