[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43340: closed ([PATCH 0/5] Speed up archive export/import)

From: GNU bug Tracking System
Subject: bug#43340: closed ([PATCH 0/5] Speed up archive export/import)
Date: Mon, 14 Sep 2020 13:48:01 +0000

Your message dated Mon, 14 Sep 2020 15:47:24 +0200
with message-id <87r1r4zd03.fsf@gnu.org>
and subject line Re: [bug#43340] [PATCH 0/5] Speed up archive export/import
has caused the debbugs.gnu.org bug report #43340,
regarding [PATCH 0/5] Speed up archive export/import
to be marked as done.

(If you believe you have received this mail in error, please contact

43340: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43340
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH 0/5] Speed up archive export/import Date: Fri, 11 Sep 2020 16:40:49 +0200

This patch series goes on top of <https://issues.guix.gnu.org/43285>.
It addresses the performance issue described at:


Specifically, it implements option #4 (spawning ‘guix authenticate’
once for the whole session, instead of spawning it every time a
store item needs to be signed or authenticated), achieving a ~15x
speedup, which is not bad.  :-)

There’s way more C++ code than I would like, and it’s probably not
pretty code (I always end up typing things like “C++ list append”
in a search engine to find the obscure incantation that does that).
There’s now a query/reply protocol between the daemon and ‘guix
authenticate’.  Nothing fancy, but it allows for strings that contain
whitespace or newlines, which is necessary here.

That’s it!


Ludovic Courtès (5):
  daemon: Generalize 'HookInstance' to 'Agent'.
  daemon: Isolate signing and signature verification functions.
  daemon: Move 'Agent' to libutil.
  daemon: Spawn 'guix authenticate' once for all.
  authenticate: Cache the ACL and key pairs.

 guix/scripts/authenticate.scm | 163 ++++++++++++++++++++++++++--------
 nix/libstore/build.cc         | 146 +++++-------------------------
 nix/libstore/local-store.cc   | 103 +++++++++++++++++----
 nix/libutil/util.cc           |  84 ++++++++++++++++++
 nix/libutil/util.hh           |  25 ++++++
 tests/guix-authenticate.sh    |  45 ++++++----
 tests/store.scm               |   8 +-
 7 files changed, 372 insertions(+), 202 deletions(-)


--- End Message ---
--- Begin Message --- Subject: Re: [bug#43340] [PATCH 0/5] Speed up archive export/import Date: Mon, 14 Sep 2020 15:47:24 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

I went ahead and pushed this series as

Changes compared to what I posted:

  • Use ‘make_shared’ and ‘isdigit’ (I’d never get a C++ developer

  • Add an enum for reply codes in ‘guix authenticate’.

  • Fix a thinko in the last patch of the series: ensure ‘loop’ is
    called even when an exception is caught.

To people who use offloading: please give it a try by running the daemon
from a recent checkout with:

  sudo -E ./pre-inst-env  guix-daemon --build-users-group=guixbuild


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]