--- Begin Message ---
Subject: |
[PATCH]Add emacs-mood-line |
Date: |
Fri, 25 Sep 2020 18:10:29 +0000 |
Hello, i made a patch to add the mood-line emacs package.
This is my first contribution, let me know if i did something wrong.
Grassi Marco
0001-Add-emacs-mood-line.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
Subject: |
Re: [bug#43624] [PATCH]Add emacs-mood-line |
Date: |
Sun, 27 Sep 2020 14:24:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
"marco.au.grassi98--- via Guix-patches" via <guix-patches@gnu.org>
writes:
> Hello, i made a patch to add the mood-line emacs package.
Thank you.
> This is my first contribution, let me know if i did something wrong.
Welcome!
I made the changes detailed below and applied your patch.
> Subject: [PATCH] Add emacs-mood-line.
I changed the commit message to
gnu: Add emacs-mood-line.
* gnu/packages/emacs-xyz.scm (emacs-mood-line): New variable.
as it is standard practice in the repository. If you use Emacs (!) and
Yasnippets, typing "add" and <TAB> in an empty commit message should
fill the template above for you.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.com/jessieh/mood-line.git")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0fh9j9fkgl433nykfzjnzap5labi4sdndfk1nv4f904ij69pmvxb"))))
I moved `origin' below `source' and the hash string on the same line as
`base32'. I also fixed indentation of the whole definition. Eventually,
I removed the ".git" suffix from the URI.
> + (build-system emacs-build-system)
> + (home-page "https://gitlab.com/jessieh/mood-line")
> + (synopsis "Minimal mode-line for Emacs")
> + (description "Mood-line is a minimal mode-line configuration that aims
> +to replicate some of the features of the
> +doom-modeline package.")
I added a reference to Emacs in the description, moved the text below
the `description' keyword (a nitpick of mine), and changed doom-modeline
to Doom modeline (nitpick about typography vs. Lisp naming practices).
> + (license license:gpl3+)))
I also added a copyright line for you in the file header. Please let me
know if I fumbled on one of its parts.
I also fixed the license, which is gpl2+ according to library's header
lines.
Regards,
--
Nicolas Goaziou
--- End Message ---