emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43673: closed ([PATCH] linux-container: Reset jailed root permission


From: GNU bug Tracking System
Subject: bug#43673: closed ([PATCH] linux-container: Reset jailed root permissions.)
Date: Thu, 01 Oct 2020 11:49:02 +0000

Your message dated Thu, 01 Oct 2020 13:48:29 +0200
with message-id <86o8lm6ub6.fsf@fsfe.org>
and subject line Re: [bug#43673] [PATCH v2] linux-container: Reset jailed root 
permissions.
has caused the debbugs.gnu.org bug report #43673,
regarding [PATCH] linux-container: Reset jailed root permissions.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
43673: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43673
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] linux-container: Reset jailed root permissions. Date: Mon, 28 Sep 2020 16:34:33 +0200
* gnu/build/linux-container.scm (mount-file-systems): Add 'chmod' call.
---
 gnu/build/linux-container.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/build/linux-container.scm b/gnu/build/linux-container.scm
index 2d4de788df..4a8bed5a9a 100644
--- a/gnu/build/linux-container.scm
+++ b/gnu/build/linux-container.scm
@@ -170,7 +170,8 @@ for the process."
     (pivot-root root put-old)
     (chdir "/")
     (umount "real-root" MNT_DETACH)
-    (rmdir "real-root")))
+    (rmdir "real-root")
+    (chmod "/" #o755)))
 
 (define* (initialize-user-namespace pid host-uids
                                     #:key (guest-uid 0) (guest-gid 0))
-- 
2.28.0




--- End Message ---
--- Begin Message --- Subject: Re: [bug#43673] [PATCH v2] linux-container: Reset jailed root permissions. Date: Thu, 01 Oct 2020 13:48:29 +0200
Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Jelle Licht <jlicht@fsfe.org> skribis:
>
>> * gnu/build/linux-container.scm (mount-file-systems): Add 'chmod' call.
>> * tests/containers.scm
>> ("call-with-container, mnt namespace, root permissions"): New test.
>
> LGTM, thanks!
>
> Ludo’.

Pushed as e7481835 on master, thanks for the fast review!


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]