bug#44798: closed ([PATCH] gnu: Add emacs-embark)

[GNU bug Tracking System]

Your message dated Tue, 24 Nov 2020 00:15:09 +0530
with message-id <87a6v7syiy.fsf@systemreboot.net>
and subject line Re: [bug#44798] [PATCH] gnu: Add emacs-embark
has caused the debbugs.gnu.org bug report #44798,
regarding [PATCH] gnu: Add emacs-embark
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44798: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44798
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: Add emacs-embark Date: Sun, 22 Nov 2020 14:40:51 +0100

0001-gnu-Add-emacs-embark.patch
Description: patch

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#44798] [PATCH] gnu: Add emacs-embark
>
>
>
>
> Date: 
>
> Tue, 24 Nov 2020 00:15:09 +0530
>
>
>
>
> Thanks for the patch! I pushed to master with the following minor edits.
>
> > +  ;; There are no tagged releases upstream on gitlab, instead we are using
> > +  ;; the most recent commit.
>
> I think you meant github, not gitlab.
>
> > +  (let ((commit "dc20b4e53c4ce1ad91100dfeb093115f2cc0b210")
> > +        (revision "0"))
> > +    (package
> > +      (name "emacs-embark")
> > +      (version (git-version "0.6" revision commit))
> > +      (source
> > +       (origin
> > +         (method git-fetch)
> > +         (uri (git-reference
> > +               (url "https://github.com/oantolin/embark";)
> > +               (commit commit)))
> > +         (sha256
> > +          (base32 "1jrvdlwip7zll5ixlnk9l0apr8hj60ysqfc47q3k4hhfyl9rawbq"))
> > +         (file-name (git-file-name name version))))
> > +      (build-system emacs-build-system)
> > +      (propagated-inputs
> > +       `(("emacs-avy" ,emacs-avy)))
> > +      (home-page "https://github.com/oantolin/embark";)
> > +      (synopsis "Emacs Mini-Buffer Actions Rooted in Keymaps")
>
> I capitalized only the first letter of the first word---Emacs. I
> downcased the rest.
>
> > +      (description
> > +       "This package provides a command embark-act (and a variant
> > +embark-act-noexit), to execute actions on the top minibuffer completion
> > +canidate: the one that would be chosen by minibuffer-force-complete")
>
> I started the string "This package..." on the same line as description,
> and added a period after minibuffer-force-complete.
>
>
> --- End Message ---