emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#44825: closed (Error in reporting guix deploy error)


From: GNU bug Tracking System
Subject: bug#44825: closed (Error in reporting guix deploy error)
Date: Thu, 26 Nov 2020 22:42:02 +0000

Your message dated Thu, 26 Nov 2020 23:41:31 +0100
with message-id <87eekfzqp0.fsf@gnu.org>
and subject line Re: bug#44825: Error in reporting guix deploy error
has caused the debbugs.gnu.org bug report #44825,
regarding Error in reporting guix deploy error
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44825: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44825
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: Error in reporting guix deploy error Date: Mon, 23 Nov 2020 13:09:42 -0500 User-agent: mu4e 1.4.13; emacs 27.1
Seems strange... the message I get:

  guix deploy: error: failed to deploy tulsi: ~A: ~S

Errors upon errors!  Formatting this time, apparently. :)

Looking at the relevant code:

(define (deploy-machine* store machine)
  "Deploy MACHINE, taking care of error handling."
  (info (G_ "deploying to ~a...~%")
        (machine-display-name machine))

  (guard (c ((message-condition? c)
             (report-error (G_ "failed to deploy ~a: ~a~%")
                           (machine-display-name machine)
                           (condition-message c)))
            ((deploy-error? c)
             (when (deploy-error-should-roll-back c)
               (info (G_ "rolling back ~a...~%")
                     (machine-display-name machine))
               (run-with-store store (roll-back-machine machine)))
             (apply throw (deploy-error-captured-args c))))
    (run-with-store store (deploy-machine machine))

    (info (G_ "successfully deployed ~a~%")
          (machine-display-name machine))))

I looked at other examples of report-error, they seemed similar.. can't
see why this one wouldn't be formatting correctly.  Any idea?



--- End Message ---
--- Begin Message --- Subject: Re: bug#44825: Error in reporting guix deploy error Date: Thu, 26 Nov 2020 23:41:31 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Hi Chris,

Christopher Lemmer Webber <cwebber@dustycloud.org> skribis:

> Seems strange... the message I get:
>
>   guix deploy: error: failed to deploy tulsi: ~A: ~S
>
> Errors upon errors!  Formatting this time, apparently. :)
>
> Looking at the relevant code:
>
> (define (deploy-machine* store machine)
>   "Deploy MACHINE, taking care of error handling."
>   (info (G_ "deploying to ~a...~%")
>         (machine-display-name machine))
>
>   (guard (c ((message-condition? c)
>              (report-error (G_ "failed to deploy ~a: ~a~%")
>                            (machine-display-name machine)
>                            (condition-message c)))

[...]

I believe this is fixed by 5842239a66683b2f5e36e95da8225e2ab7f7dac3.

Thanks!

Ludo’.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]