bug#45133: closed (Add ocaml reactiveData)

[GNU bug Tracking System]

Your message dated Tue, 15 Dec 2020 15:49:56 +0100
with message-id <20201215154956.4350a986@tachikoma.lepiller.eu>
and subject line Re: [bug#45133] Add ocaml reactiveData
has caused the debbugs.gnu.org bug report #45133,
regarding Add ocaml reactiveData
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
45133: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45133
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: Add ocaml reactiveData Date: Wed, 09 Dec 2020 15:58:35 +0100 User-agent: Evolution 3.34.2

Dear guix,

I want to have js_of_ocaml into guix. Here is a dependency of it,
reactiveData. It is a simple package, but the build system changed from
ocaml-build-system to dune-build-system between the last release and
now, so I think we should use the latest commit.

Best regards,

divoplade

0001-gnu-add-ocaml-reactiveData.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#45133] Add ocaml reactiveData
>
>
>
>
> Date: 
>
> Tue, 15 Dec 2020 15:49:56 +0100
>
>
>
>
> Pushed as 190187326ad7516dd6728eed7bb6ef2d4f92897a.
>
> I made a small number of changes to your patch:
>
> In the commit message, added capitalization (add -> Add) and full
> stops, removed spaces at the beginning of the `*` line.
>
> In the patch, added a copyright line for you, added a comment to the
> phase where we delete the Makefile, fixed the description (guix lint
> should have told you so), and added an upstream-name property so guix
> refresh knows where to look for newer versions. In general, it's not
> needed because guix-name->opam-name works well, but here we lost
> capitalization, so we need to explicitely tell it which name it is.
>
> Thank you!
>
>
> --- End Message ---