bug#45958: closed ([PATCH core-updates v3 1/2] utils: Retrieve the store prefix from NIX_STORE_DIR, not STORE_DIR.)

[GNU bug Tracking System]

Your message dated Tue, 26 Jan 2021 22:58:53 -0500
with message-id <87sg6nyqrm.fsf@gmail.com>
and subject line Re: bug#45958: [PATCH core-updates v3 1/2] utils: Retrieve the 
store prefix from NIX_STORE_DIR, not STORE_DIR.
has caused the debbugs.gnu.org bug report #45958,
regarding [PATCH core-updates v3 1/2] utils: Retrieve the store prefix from 
NIX_STORE_DIR, not STORE_DIR.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
45958: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45958
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH core-updates v3 1/2] utils: Retrieve the store prefix from NIX_STORE_DIR, not STORE_DIR.
>
>
>
>
> Date: 
>
> Mon, 18 Jan 2021 11:51:20 -0500
>
>
>
>
> On the daemon side, nixStore gets set to the environment variable
> NIX_STORE_DIR, else the environment variable NIX_STORE else the compile time
> macro NIX_STORE_DIR (see the Settings::processEnvironment method in
> nix/libstore/globals.cc).  Hence, it is more appropriate to lookup the
> environment variable NIX_STORE_DIR than NIX_STORE in (guix build utils).
>
> * guix/build/utils.scm (%store-directory): Call getenv with NIX_STORE_DIR
> instead of NIX_STORE.
> ---
>  guix/build/utils.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/build/utils.scm b/guix/build/utils.scm
> index 76180e67e0..2cbdb31505 100644
> --- a/guix/build/utils.scm
> +++ b/guix/build/utils.scm
> @@ -144,7 +144,7 @@
>  
>  (define (%store-directory)
>    "Return the directory name of the store."
> -  (or (getenv "NIX_STORE")
> +  (or (getenv "NIX_STORE_DIR")
>        "/gnu/store"))
>  
>  (define (store-file-name? file)
> -- 
> 2.29.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#45958: [PATCH core-updates v3 1/2] utils: Retrieve the store prefix from NIX_STORE_DIR, not STORE_DIR.
>
>
>
>
> Date: 
>
> Tue, 26 Jan 2021 22:58:53 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
> > On the daemon side, nixStore gets set to the environment variable
> > NIX_STORE_DIR, else the environment variable NIX_STORE else the compile time
> > macro NIX_STORE_DIR (see the Settings::processEnvironment method in
> > nix/libstore/globals.cc).  Hence, it is more appropriate to lookup the
> > environment variable NIX_STORE_DIR than NIX_STORE in (guix build utils).
> >
> > * guix/build/utils.scm (%store-directory): Call getenv with NIX_STORE_DIR
> > instead of NIX_STORE.
> > ---
> >  guix/build/utils.scm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/guix/build/utils.scm b/guix/build/utils.scm
> > index 76180e67e0..2cbdb31505 100644
> > --- a/guix/build/utils.scm
> > +++ b/guix/build/utils.scm
> > @@ -144,7 +144,7 @@
> >  
> >  (define (%store-directory)
> >    "Return the directory name of the store."
> > -  (or (getenv "NIX_STORE")
> > +  (or (getenv "NIX_STORE_DIR")
> >        "/gnu/store"))
> >  
> >  (define (store-file-name? file)
>
> I found that both environment variables should be honored and pushed
> with a revised explanation in 47a6a938c3c4d0bbe7b6a3c64ff75d7bfb2f24fb.
>
> Closing,
>
> Maxim
>
>
> --- End Message ---