bug#46243: closed (26.3; If invoke menu item that reads a char, get keystrokes echo)

[GNU bug Tracking System]

Your message dated Thu, 04 Feb 2021 19:37:24 +0200
with message-id <83blczray3.fsf@gnu.org>
and subject line Re: bug#46243: [External] : Re: bug#46243: 26.3; If invoke 
menu item that reads a char, get keystrokes echo
has caused the debbugs.gnu.org bug report #46243,
regarding 26.3; If invoke menu item that reads a char, get keystrokes echo
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46243: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46243
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26.3; If invoke menu item that reads a char, get keystrokes echo
>
>
>
>
> Date: 
>
> Mon, 1 Feb 2021 18:50:56 +0000
>
>
>
>
> There's no doubt a simpler thing to repro this with.  Sorry, I'm pressed
> for time.
>
> I see this starting with Emacs 24, and still in Emacs 27.1.  There's no
> such problem before Emacs 24.
>
> If I have a menu item that reads a character, the prompt for that read
> is not seen; the menu selection key sequence gets echoed instead.  This
> shouldn't happen (should it?).
>
> Binding `echo-keystrokes' in the command's `interactive' spec doesn't
> prevent this.  The workaround I've found is to add a call to (message
> nil).
>
> Example command:
>
> (defun diredp-mark-with-char (char &optional arg)
>   "Mark this line with CHAR.
> With numeric prefix arg N, mark the next N lines."
>   (interactive
>    (progn (message nil)
>           (list (read-char "Mark this line with char: ")
>                 (prefix-numeric-value current-prefix-arg))))
>   (let ((dired-marker-char  char))
>     (dired-mark arg)))
>
> If the `interactive' spec does not have that (message nil) then it
> doesn't work - you then see the menu-invocation key sequence instead of
> the prompt.  And this is so whether I use "cChar: \np" or a sexp with
> `read-char'.
>
> If I change to reading a string then there's no such problem:
>
> (defun diredp-mark-with-char (char &optional arg)
>   "Mark this line with CHAR.
> With numeric prefix arg N, mark the next N lines."
>   (interactive "sChar: \np")
>   (let ((dired-marker-char  (string-to-char char)))
>     (dired-mark arg)))
>
> So that's another possible workaround.  (Is one of those better?)
>
> Haven't been able to see why this problem occurs.
>
> This is the menu item I have for the above command:
>
> (define-key diredp-marks-mark-menu [diredp-mark-with-char]
>   '(menu-item "Mark This with Char..." diredp-mark-with-char
>               :visible (not (diredp-nonempty-region-p))
>               :help "Mark this line with a character you type"))
>
> I see the problem also with `easy-menu-create-menu':
>
> (easy-menu-create-menu
>  "This File"
>  '(["Mark with Char..." diredp-mark-with-char]))
>
> Please advise.  Am I missing something?  As I say, this was not a
> problem before Emacs 24.
>
> In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
>  of 2019-08-29
> Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
> Windowing system distributor `Microsoft Corp.', version 10.0.18362
> Configured using:
>  `configure --without-dbus --host=x86_64-w64-mingw32
>  --without-compress-install 'CFLAGS=-O2 -static -g3''
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#46243: [External] : Re: bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo
>
>
>
>
> Date: 
>
> Thu, 04 Feb 2021 19:37:24 +0200
>
>
>
>
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Cc: drew.adams@oracle.com,  46243@debbugs.gnu.org
> > Date: Thu, 04 Feb 2021 11:50:14 -0500
> > 
> > > So I propose the much simpler patch below.  It may look like a kludgey
> > > band-aid at first sight, but OTOH consider this:
> > 
> > Looks OK to me.  It's fairly unusual to want echo-keystrokes working
> > when there's a prompt in any case.  The only case I can think of right
> > now is for `C-h k` and `C-h c` (but these use `read-key-sequence` so
> > I think they won't be affected).
>
> Thanks.  I verified that "C-h k" works, including when invoked via the
> menus, and installed this on the master branch.  With that, I'm
> closing this bug.
>
>
> --- End Message ---