emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#44435: closed ([PATCH 0/1] services: Add Transmission Daemon)


From: GNU bug Tracking System
Subject: bug#44435: closed ([PATCH 0/1] services: Add Transmission Daemon)
Date: Fri, 12 Feb 2021 07:15:01 +0000

Your message dated Fri, 12 Feb 2021 15:15:57 +0800
with message-id 
<OSZP286MB0664D2F03DA0593A4F7EFF19A38B9@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM>
and subject line Re: [bug#44435] [PATCH v3 0/1] services: Add Transmission 
Daemon
has caused the debbugs.gnu.org bug report #44435,
regarding [PATCH 0/1] services: Add Transmission Daemon
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44435: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44435
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH 0/1] services: Add Transmission Daemon Date: Wed, 4 Nov 2020 07:37:31 -0500
This patch adds a service type for Transmission Daemon, the headless variant
of the Transmission BitTorrent client (https://transmissionbt.com/). Running
the client as a service this way makes it possible to share files over
BitTorrent continuously without requiring a user be logged in.

I've tried to make this as complete as possible but am especially interested
in geting feedback as this is my first attempt at creating a service
definition. A few things to point out:

- I've placed the code in a new "(gnu services file-sharing)" module and the
  documentation in a new "File-Sharing Services" section of the manual, only
  because these names seemed the most natural to me. ("Peer-to-peer" would be
  too broad a categorization, I think, while "BitTorrent" too narrow.)

- The module exports two procedures, "transmission-password-hash" and
  "transmission-random-salt", that together are my solution to the problem of
  assigning a value to the daemon's "rpc-password" configuration setting.

  Transmission clients seem to expect the user to supply a password in
  plaintext in their "settings.json" file. At startup, the client generates a
  random, eight-character salt value; hashes it and the password together; and
  writes the result back to the settings file, after which the password
  remains obscured. This obviously violates the functional nature of Guix, as
  we don't expect services to be rewriting their own configuration files and
  the use of a random salt value makes the process non-repeatable anyway.

  I've documented in the manual how a user can use these two procedures to
  create a suitable value for "rpc-password" that remains stable across system
  reconfigurations, but perhaps you know of a better (or more conventional)
  approach.

- I've added a custom "stop" procedure to the Shepherd service that gives the
  daemon time to shut down before eventually killing its process. This is
  necessary since the daemon performs some housekeeping and sends a final
  update to BitTorrent trackers before it exits, which can take several
  seconds or more; without this code, restarting the service usually fails as
  the new daemon process finds the old one is still running and attached to
  the port used for peer connections.

  Again, the approach I've used to handle this seems reasonable to me but
  perhaps you know of something better.

--
Simon South
simon@simonsouth.net


Simon South (1):
  services: Add transmission-daemon service.

 doc/guix.texi                 | 799 +++++++++++++++++++++++++++++++++
 gnu/local.mk                  |   1 +
 gnu/services/file-sharing.scm | 806 ++++++++++++++++++++++++++++++++++
 3 files changed, 1606 insertions(+)
 create mode 100644 gnu/services/file-sharing.scm

-- 
2.28.0




--- End Message ---
--- Begin Message --- Subject: Re: [bug#44435] [PATCH v3 0/1] services: Add Transmission Daemon Date: Fri, 12 Feb 2021 15:15:57 +0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Simon South <simon@simonsouth.net> writes:

> Here's a new version of this patch that incorporates feedback[0] from Ludovic:
> [...]

I configure my system with this and test a torrent download.

Pushed, thank you for this patch and ludo for the review!


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]