bug#46620: closed ([PATCH] gnu: emacs-kbd: new package)

[GNU bug Tracking System]

Your message dated Thu, 18 Feb 2021 21:07:34 +0100
with message-id <878s7lcf7d.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#46620] Fixed git patch
has caused the debbugs.gnu.org bug report #46620,
regarding [PATCH] gnu: emacs-kbd: new package
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46620: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46620
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: emacs-kbd: new package Date: Thu, 18 Feb 2021 17:19:51 +0000

---
Hello!
 gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cb2a5dc56f..c86732a164 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3146,6 +3146,36 @@ depicting stroke orders for all Kanji.  The collection is a slightly modified
 and limited version of the images provided by the KanjiVG project.")
       (license license:gpl3+))))
 
+(define-public emacs-kbd
+  ;; Package has no release.  Version is extracted from "Version:" keyword in
+  ;; main file.
+  (let ((commit "a7f4c9b9770fa6a58895c5f121df82652bb1b737")
+        (revision "0"))
+    (package
+      (name "emacs-kbd")
+      (version (git-version "0.0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/slotThe/kbd-mode")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0jv9yfsncgf96308c041hvps3jlc151xb0aipm0vasbma3x83ygm"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'enter-lisp-directory (lambda _ (chdir "lisp") #t)))))
+      (home-page "https://github.com/slotThe/kbd-mode")
+      (synopsis "Emacs minor mode for syntax highlighting kmonad's .kbd files.")
+      (description
+       "This minor mode provides syntax highlighting for Lisp-like DSL used in kmonad's
+configuration files (.kbd). It inherits from `emacs-lisp-mode' to provide sensible
+parenthesis handling.")
+      (license license:gpl3+))))
+
 (define-public emacs-keycast
   (package
     (name "emacs-keycast")
--
2.30.1

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#46620] Fixed git patch
>
>
>
>
> Date: 
>
> Thu, 18 Feb 2021 21:07:34 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Юрий Холодков <urist.mckorobochka@gmail.com> writes:
>
> > Subject: [PATCH] gnu: emacs-kbd: new package
>
> I committed your patch with the minor changes detailed below.
>
> > +       `(#:phases
> > +         (modify-phases %standard-phases
> > +           (add-after 'unpack 'enter-lisp-directory (lambda _ (chdir
> > "lisp") #t)))))
>
> I moved the lambda on the line below.
>
> > +      (synopsis "Emacs minor mode for syntax highlighting kmonad's .kbd
> > files.")
>
> I slightly shortened synopsis and used @file{.kbd}.
>
> > +      (description
> > +       "This minor mode provides syntax highlighting for Lisp-like DSL
> > used in kmonad's
> > +configuration files (.kbd). It inherits from `emacs-lisp-mode' to provide
> > sensible
> > +parenthesis handling.")
>
> I removed the second sentence in description, since it is not so useful
> when trying to explain what the library is about. I also used
> @file{.kbd}.
>
> I added a copyright line for you at the top of the "emacs-xyz.scm" file.
> I also added an appropriate commit message.
>
> Note that your patch didn't apply cleanly. You may use "git
> format-patch". If you did, something else broke your patch somehow.
>
> Thanks!
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---